Rollup of 4 pull requests #132631

workingjubilee · 2024-11-05T09:34:25Z

Successful merges:

Stabilise const_char_encode_utf16. #132153 (Stabilise const_char_encode_utf16.)
[core/fmt] Replace checked slice indexing by unchecked to support panic-free code #132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code)
PassWrapper: adapt for new parameter in LLVM #132600 (PassWrapper: adapt for new parameter in LLVM)
triagebot: ping wg-const-eval when relevant files change #132630 (triagebot: ping wg-const-eval when relevant files change)

r? @ghost
@rustbot modify labels: rollup

Fixes rust-lang#126425 Replace the potentially panicking `[]` indexing with `get_unchecked()` to prevent linking with panic-related code.

@rustbot

llvm/llvm-project@390300d added a new parameter to some callbacks, so we have to handle them. @rustbot label: +llvm-main

…, r=dtolnay Stabilise `const_char_encode_utf16`. Closes: rust-lang#130660 This PR stabilises the `const_char_encode_utf16` feature gate (i.e. support for `char::encode_utf16` in constant expressions). ~~Note that the linked tracking issue is as of this writing currently awaiting FCP until 2024-11-02.~~

…joboet [core/fmt] Replace checked slice indexing by unchecked to support panic-free code Fixes rust-lang#126425 Replace the potentially panicking `[]` indexing with `get_unchecked()` to prevent linking with panic-related code.

…=Zalathar PassWrapper: adapt for new parameter in LLVM llvm/llvm-project@390300d added a new parameter to some callbacks, so we have to handle them. `@rustbot` label: +llvm-main

triagebot: ping wg-const-eval when relevant files change This adds pings for `@rust-lang/wg-const-eval` when anything in rustc_const_eval changes (in particular, this covers the const checking logic, which was so far not covered by any notifications). I also added pings for things that so far only pinged the Miri group, since those parts are relevant to wg-const-eval as well.

workingjubilee · 2024-11-05T09:34:37Z

@bors r+ rollup=never p=5

bors · 2024-11-05T09:34:40Z

📌 Commit 5b1c626 has been approved by workingjubilee

It is now in the queue for this repository.

…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132153 (Stabilise `const_char_encode_utf16`.) - rust-lang#132473 ([core/fmt] Replace checked slice indexing by unchecked to support panic-free code) - rust-lang#132600 (PassWrapper: adapt for new parameter in LLVM) - rust-lang#132630 (triagebot: ping wg-const-eval when relevant files change) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-11-05T12:21:10Z

⌛ Testing commit 5b1c626 with merge 977ad50...

rust-log-analyzer · 2024-11-05T16:24:23Z

The job x86_64-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [run-make] tests\run-make\zero-extend-abi-param-passing ... ok
test [run-make] tests\run-make\test-benches ... ok
test [run-make] tests\run-make\share-generics-export-again ... ok
test [run-make] tests\run-make\rustc-crates-on-stable ... ok
Terminate batch job (Y/N)? 
##[error]The operation was canceled.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version
git version 2.47.0.windows.1

bors · 2024-11-05T16:24:37Z

💔 Test failed - checks-actions

workingjubilee · 2024-11-05T18:37:42Z

@bors retry

bors · 2024-11-05T18:59:03Z

⌛ Testing commit 5b1c626 with merge bc5cf99...

bors · 2024-11-05T22:42:08Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing bc5cf99 to master...

rust-timer · 2024-11-05T22:43:17Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#132153	Stabilise `const_char_encode_utf16`.	`73bdbea85ca2baf6ee4a201a4726a04c3d94a04b` (link)
#132473	[core/fmt] Replace checked slice indexing by unchecked to s…	`ffad505444b89e8b2e81bd5bcf2a9fdf0babf0ac` (link)
#132600	PassWrapper: adapt for new parameter in LLVM	`6ab960f90b5060b487ed3c15543fa217736ff274` (link)
#132630	triagebot: ping wg-const-eval when relevant files change	`406c61c66750ea6eab99b858eb70759f09d8af63` (link)

previous master: e8c698bb3b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-11-06T00:00:26Z

Finished benchmarking commit (bc5cf99): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	10
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	38
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	10

Bootstrap: 779.96s -> 779.813s (-0.02%)
Artifact size: 335.30 MiB -> 335.27 MiB (-0.01%)

bjoernager and others added 10 commits November 4, 2024 13:09

Stabilise 'const_char_encode_utf16';

7faa84e

Replace checked slice indexing by unchecked to support panic-free code

02a1ab8

Fixes rust-lang#126425 Replace the potentially panicking `[]` indexing with `get_unchecked()` to prevent linking with panic-related code.

Updated SAFETY comment to address underflow

37f48da

Fixed typo, rebased

65d8f1b

PassWrapper: adapt for new parameter in LLVM

e8d1744

llvm/llvm-project@390300d added a new parameter to some callbacks, so we have to handle them. @rustbot label: +llvm-main

triagebot: ping wg-const-eval when relevant files change

b81e919

Rollup merge of rust-lang#132600 - durin42:llvm-20-passbuilder-arg, r…

ea08bbe

…=Zalathar PassWrapper: adapt for new parameter in LLVM llvm/llvm-project@390300d added a new parameter to some callbacks, so we have to handle them. `@rustbot` label: +llvm-main

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2024

workingjubilee closed this Nov 5, 2024

workingjubilee reopened this Nov 5, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2024

bors merged commit bc5cf99 into rust-lang:master Nov 5, 2024
13 checks passed

rustbot added this to the 1.84.0 milestone Nov 5, 2024

bors mentioned this pull request Nov 5, 2024

Add new unstable feature const_eq_ignore_ascii_case #131721

Merged

workingjubilee deleted the rollup-dx0krqp branch November 6, 2024 00:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #132631

Rollup of 4 pull requests #132631

Uh oh!

workingjubilee commented Nov 5, 2024

Uh oh!

workingjubilee commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

rust-log-analyzer commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

workingjubilee commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

Uh oh!

rust-timer commented Nov 5, 2024

Uh oh!

rust-timer commented Nov 6, 2024

Uh oh!

Uh oh!

Rollup of 4 pull requests #132631

Rollup of 4 pull requests #132631

Uh oh!

Conversation

workingjubilee commented Nov 5, 2024

Uh oh!

workingjubilee commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

rust-log-analyzer commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

workingjubilee commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

bors commented Nov 5, 2024

Uh oh!

Uh oh!

rust-timer commented Nov 5, 2024

Uh oh!

rust-timer commented Nov 6, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!