-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Implement missing logics in exported_private_dependencies
lint
#134176
Conversation
rustbot has assigned @petrochenkov. Use |
This comment has been minimized.
This comment has been minimized.
69cd0c2
to
c98257c
Compare
c98257c
to
6e8f9dd
Compare
exported_private_dependencies
checksexported_private_dependencies
lint
r? compiler |
|
Actually, I'm preparing another PR that fixes #119428 once and for all with some changes in ast path lowering and nameres resolves. |
…rom `rustc_privacy`
Yes, most likely. See, for example, the |
I started reviewing this and I was sure that Technically, the regular type privacy lints (not private dep leaks) should be reported there as well, it was just skipped due to many false positives. Closing in favor of #138317. |
…r-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
…r-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
Rollup merge of rust-lang#138317 - petrochenkov:libsearch3, r=compiler-errors privacy: Visit types and traits in impls in type privacy lints With one exception to avoid false positives. Fixes the same issue as rust-lang#134176.
Fixes some cases of #71043