Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sanitizers on MSVC CI jobs #136155

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable sanitizers on MSVC CI jobs #136155

wants to merge 1 commit into from
+4 −4

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 27, 2025 •
edited
Loading

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

@tmiasko
Enable sanitizers on MSVC CI jobs
1ba2153 
Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 27, 2025
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
@bors
Auto merge of rust-lang#136155 - tmiasko:msvc-enable-sanitizers, r=<try>
a92c3c2 
Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

try-jobs: i686-msvc-1
try-jobs: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Trying commit 1ba2153 with merge a92c3c2...

@bors
Copy link
Contributor

bors commented Jan 27, 2025

☀️ Try build successful - checks-actions
Build commit: a92c3c2 (a92c3c2c9b04ac8193bd22d16e268abaf0ec8c63)

@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2025

i686-msvc-1, i686-msvc-2:
@bors try

@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Trying commit 1ba2153 with merge 75c98e7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
@bors
Auto merge of rust-lang#136155 - tmiasko:msvc-enable-sanitizers, r=<try>
75c98e7 
Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

try-job: i686-msvc-1
try-job: i686-msvc-2
@tmiasko tmiasko marked this pull request as ready for review January 27, 2025 23:56
@bors
Copy link
Contributor

bors commented Jan 28, 2025

☀️ Try build successful - checks-actions
Build commit: 75c98e7 (75c98e70dddf7384016c285910e91e7f472aad3c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmiasko @rustbot @bors @Mark-Simulacrum