Render pattern types nicely in mir dumps #136176
Merged
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
commented
Jan 28, 2025
| scope 1 { | ||
| debug x => const 2_u32 is 1..=; | ||
| scope 2 { | ||
| debug y => const 0_u32 is 1..=; |
There was a problem hiding this comment.
This one is fun. We do render as transmute for other things that are invalid (e.g. chars that aren't valid chars, or bools that aren't 0 or 1), but it's harder to do this here without running validation on it... and I'm not sure all the extra logic for doing so would be worth it.
compiler-errors
approved these changes
Jan 28, 2025
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
scottmcm
reviewed
Jan 28, 2025
tests/mir-opt/pattern_types.rs
Outdated
| fn main() { | ||
| // CHECK: debug x => const {transmute(0x00000002): (u32) is 1..=} | ||
| let x: pattern_type!(u32 is 1..) = unsafe { std::mem::transmute(2) }; | ||
| // CHECK: debug y => const {transmute(0x00000000): (u32) is 1..=} |
There was a problem hiding this comment.
Hmm, definitely interesting. I guess this is falling under the "compilation doesn't have to detect UB" rule?
There was a problem hiding this comment.
Well... we kinda do because there could be no UB, just const prop crossing a check that prevents UB. So this could happen in dead code. So there is an argument for showing that in pretty printing. I'll see if I can pull out the logic we use in const validation in a way that makes it reusable here
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 29, 2025
…ompiler-errors Render pattern types nicely in mir dumps avoid falling through to the fallback rendering that just does a hex dump r? `@scottmcm` best reviewed commit by commit
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns) - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20) - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests) - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS) - rust-lang#136166 (interpret: is_alloc_live: check global allocs last) - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items) - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature) - rust-lang#136176 (Render pattern types nicely in mir dumps) - rust-lang#136186 (uefi: process: Fix args) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2025
Rollup of 9 pull requests Successful merges: - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns) - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20) - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests) - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS) - rust-lang#136166 (interpret: is_alloc_live: check global allocs last) - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items) - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature) - rust-lang#136176 (Render pattern types nicely in mir dumps) - rust-lang#136186 (uefi: process: Fix args) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 29, 2025
Rollup merge of rust-lang#136176 - oli-obk:pattern-type-mir-opts, r=compiler-errors Render pattern types nicely in mir dumps avoid falling through to the fallback rendering that just does a hex dump r? ``@scottmcm`` best reviewed commit by commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid falling through to the fallback rendering that just does a hex dump
r? @scottmcm
best reviewed commit by commit