-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #136203
Rollup of 9 pull requests #136203
Conversation
The purpose of this test wasn't obvious. Add a comment.
[`rustc-rayon v0.5.1`](rust-lang/rustc-rayon#14) added `indexmap` implementations that will allow `indexmap` to drop its own "internal-only" implementations. (This is separate from `indexmap`'s implementation for normal `rayon`.)
Make docs for AtomicUsize::from_mut platform-independent fixes rust-lang#133342
…malized, r=lcnr -Znext-solver: "normalize" signature before checking it mentions self in `deduce_closure_signature` Fixes rust-lang/trait-system-refactor-initiative#138 r? ``@lcnr`` Tbh I wrote so much comments I don't feel like writing it all again but as a description.
…k, r=RalfJung Implement MIR const trait stability checks Addresses rust-lang/project-const-traits#16 cc ``@rust-lang/project-const-traits`` r? ``@RalfJung``
Pass spans to `perform_locally_in_new_solver` Nothing changes yet, but we may be able to use these spans in the future once we start dealing w the response region constraints better. r? lcnr
…tems, r=flip1995 [Clippy] Add vec_reserve & vecdeque_reserve diagnostic items I’m currently working on reviving this lint (rust-lang/rust-clippy#10157), and there was [a comment](rust-lang/rust-clippy#10157 (comment)) from ``@flip1995`` regarding the necessity of adding new diagnostic items.
…-errors Arbitrary self types v2: explain test. The purpose of this test wasn't obvious, as ```@traviscross``` noted. Add a comment. Confession: although this test was added to demonstrate this particular corner-case, I can no longer reproduce the original problem, even if I adjust `rustc` to do the "wrong" thing. I have spent several hours trying to adjust the case to trigger the "faulty" behavior with no success. This test may therefore not be as useful as it originally was. But it still seems worthwhile retaining as a regression test that we don't break things in these quirky circumstances. Ideally we'd find a new test which tests this behavior but I've failed to come up with one. r? ```@traviscross```
…mpiler-errors Flip the `rustc-rayon`/`indexmap` dependency order [`rustc-rayon v0.5.1`](rust-lang/rustc-rayon#14) added `indexmap` implementations that will allow `indexmap` to drop its own "internal-only" implementations. (This is separate from `indexmap`'s implementation for normal `rayon`.)
Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
Update username in build helper example no typos have been made in the process of creating this pull request r? pietroalbini
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 77a455303b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (bf1b174): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.7%, secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.05s -> 770.985s (-0.01%) |
Successful merges:
deduce_closure_signature
#135892 (-Znext-solver: "normalize" signature before checking it mentions self indeduce_closure_signature
)perform_locally_in_new_solver
#136066 (Pass spans toperform_locally_in_new_solver
)rustc-rayon
/indexmap
dependency order #136149 (Flip therustc-rayon
/indexmap
dependency order)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup