compiletest: add {ignore,only}-rustc_abi-x86-sse2 directives
#137074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
This comment has been minimized.
This comment has been minimized.
jieyouxu
added
S-waiting-on-author
jieyouxu
commented
Feb 15, 2025
Comment on lines
+894
to
+905
| // FIXME: this test will fail against stage 0 until #137037 changes reach beta. | ||
| #[cfg_attr(bootstrap, ignore)] | ||
| fn test_rustc_abi() { | ||
| let config = cfg().target("i686-unknown-linux-gnu").build(); | ||
| assert_eq!(config.target_cfg().rustc_abi, Some("x86-sse2".to_string())); | ||
| assert!(check_ignore(&config, "//@ ignore-rustc_abi-x86-sse2")); | ||
| assert!(!check_ignore(&config, "//@ only-rustc_abi-x86-sse2")); | ||
| let config = cfg().target("x86_64-unknown-linux-gnu").build(); | ||
| assert_eq!(config.target_cfg().rustc_abi, None); | ||
| assert!(!check_ignore(&config, "//@ ignore-rustc_abi-x86-sse2")); | ||
| assert!(check_ignore(&config, "//@ only-rustc_abi-x86-sse2")); | ||
| } |
There was a problem hiding this comment.
Note that #137037 changes is in master but hasn't reached beta yet, so the rustc_abi field isn't present for i686=unknown-linux-gnu yet.
jieyouxu
removed
the
S-waiting-on-author
|
@rustbot ready |
rustbot
added
the
S-waiting-on-review
onur-ozkan
reviewed
Feb 15, 2025
onur-ozkan
approved these changes
Feb 15, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 15, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127581 (Fix crate name validation) - rust-lang#136490 (Do not allow attributes on struct field rest patterns) - rust-lang#136808 (Try to recover from path sep error in type parsing) - rust-lang#137055 (rustdoc: Properly restore search input placeholder) - rust-lang#137068 (fix(rustdoc): Fixed `Copy Item Path` in rust doc) - rust-lang#137070 (Do not generate invalid links in job summaries) - rust-lang#137074 (compiletest: add `{ignore,only}-rustc_abi-x86-sse2` directives) - rust-lang#137076 (triagebot.toml: ping me on changes to `tests/rustdoc-json`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#127581 (Fix crate name validation) - rust-lang#136490 (Do not allow attributes on struct field rest patterns) - rust-lang#136808 (Try to recover from path sep error in type parsing) - rust-lang#137055 (rustdoc: Properly restore search input placeholder) - rust-lang#137068 (fix(rustdoc): Fixed `Copy Item Path` in rust doc) - rust-lang#137070 (Do not generate invalid links in job summaries) - rust-lang#137074 (compiletest: add `{ignore,only}-rustc_abi-x86-sse2` directives) - rust-lang#137076 (triagebot.toml: ping me on changes to `tests/rustdoc-json`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2025
Rollup merge of rust-lang#137074 - jieyouxu:rustc_abi, r=onur-ozkan compiletest: add `{ignore,only}-rustc_abi-x86-sse2` directives As requested in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/compiletest.20target.20selection.20is.20way.20too.20rigid, cc `@RalfJung` r? bootstrap (or compiler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/compiletest.20target.20selection.20is.20way.20too.20rigid, cc @RalfJung
r? bootstrap (or compiler)