Skip to content

Conversation

Noratrieb
Copy link
Member

This reverts commit bb2cc59, reversing changes made to bca5f37.

This PR made rustc tools no longer work after dist.

See #137469. Maybe @onur-ozkan comes up with a fix before nightly is released in about ~13 hours, but if not then we should land this in the meantime to avoid releasing a broken nightly. Let's keep this revert ready in case it's needed.

r? @onur-ozkan

…stages, r=jieyouxu,Kobzol"

This reverts commit bb2cc59, reversing
changes made to bca5f37.

This PR made rustc tools no longer work after dist.
@Noratrieb
Copy link
Member Author

@bors p=100

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

This PR modifies src/bootstrap/defaults.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 23, 2025
@bors
Copy link
Collaborator

bors commented Feb 24, 2025

☔ The latest upstream changes (presumably #137476) made this pull request unmergeable. Please resolve the merge conflicts.

@onur-ozkan
Copy link
Member

fyi #137476 is merged and problem is solved.

@Noratrieb Noratrieb closed this Feb 24, 2025
@Noratrieb Noratrieb deleted the revert-tools branch February 24, 2025 06:16
@onur-ozkan onur-ozkan removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants