New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added `unchecked_div` and `unchecked_rem` to signed and unsigned numerical types #137598

Open

madhav-madhusoodanan wants to merge 2 commits into rust-lang:master from madhav-madhusoodanan:feature-unchecked-div-rem

+120 −0

Contributor

madhav-madhusoodanan commented Feb 25, 2025

Context

Adds unchecked_div and unchecked_rem to signed and unsigned numerical types in core.
This is an unstable addition.

Related Issue

Tracking Issue for unchecked_div_rem #136716

rustbot assigned tgross35

Collaborator

rustbot commented Feb 25, 2025

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review T-libs labels

madhav-madhusoodanan changed the title ~~[WIP] Added unchecked_div and unchecked_rem to signed and unsigned numerical types~~ Added unchecked_div and unchecked_rem to signed and unsigned numerical types

This comment has been minimized.

Sign in to view

madhav-madhusoodanan commented

View reviewed changes

library/core/src/num/int_macros.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch 2 times, most recently from ed68857 to 1a6551b Compare

February 25, 2025 11:44

Contributor

tgross35 commented Feb 25, 2025

r? @the8472 since you expressed some concerns at #136716

rustbot assigned the8472 and unassigned tgross35

Member

the8472 commented Feb 25, 2025 •

edited

Loading

On the tracking issue I was mostly voicing conern about the naming, i.e. having two functions with the same name but different safety preconditions.
The libs-API team already accepted this as unstable addition so my concern shouldn't be a blocker for this PR, but I'd want to be reconsidered before stabilization, that's why I noted it on the tracking issue.

Sky9x suggested changes

View reviewed changes

Contributor

Sky9x left a comment

Some of the requested changes are only on 1 of the functions, please make sure they are applied to all 4 (if applicable).

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Show resolved Hide resolved

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch from 1a6551b to dee4e5c Compare

February 26, 2025 06:59

This comment has been minimized.

Sign in to view

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch from dee4e5c to e5eddbd Compare

February 26, 2025 07:13

Contributor Author

madhav-madhusoodanan commented Feb 26, 2025

Have updated documentation and corrected the failure condition being passed to assert_unsafe_precondition for unchecked_div and unchecked_rem functions in int_macros.rs.

Special thanks to @Sky9x for the suggestions.

@rustbot review

This comment has been minimized.

Sign in to view

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch from e5eddbd to 2949b77 Compare

February 26, 2025 07:38

madhav-madhusoodanan changed the title ~~Added unchecked_div and unchecked_rem to signed and unsigned numerical types~~ [WIP] Added unchecked_div and unchecked_rem to signed and unsigned numerical types

This comment has been minimized.

Sign in to view

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch 2 times, most recently from 0878b5e to 5d40a59 Compare

February 26, 2025 09:48

madhav-madhusoodanan changed the title ~~[WIP] Added unchecked_div and unchecked_rem to signed and unsigned numerical types~~ Added unchecked_div and unchecked_rem to signed and unsigned numerical types

madhav-madhusoodanan requested a review from Sky9x

February 26, 2025 12:43

Sky9x approved these changes

View reviewed changes

Contributor

Sky9x left a comment

LGTM!
Tip: You can collapse review comments by clicking on "Resolve Conversation" once you've addressed it

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Outdated Show resolved Hide resolved

library/core/src/num/uint_macros.rs Show resolved Hide resolved

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch from 5d40a59 to 8d2a5b6 Compare

February 26, 2025 19:32

quaternic reviewed

View reviewed changes

library/core/src/num/int_macros.rs Outdated Show resolved Hide resolved

madhav-madhusoodanan added 2 commits

March 2, 2025 09:50


          added unchecked_div for signed and unsigned types

df83987


          added unchecked_rem for signed and unsigned types

2c9342d

madhav-madhusoodanan force-pushed the feature-unchecked-div-rem branch from 8d2a5b6 to 2c9342d Compare

March 2, 2025 04:21

Contributor Author

madhav-madhusoodanan commented Mar 28, 2025 •

edited

Loading

I would be grateful if you could please take a look at this PR @the8472.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review T-libs