Skip to content

Get rid of EscapeDebugInner. #138237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Get rid of EscapeDebugInner. #138237

wants to merge 1 commit into from
+210 −92

Conversation

reitermarkus
Copy link
Contributor

I read the note on EscapeDebugInner and thought I'd give it a try.

@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 8, 2025
@reitermarkus reitermarkus force-pushed the remove-escape-debug-inner branch 3 times, most recently from 57c0a80 to 0854482 Compare March 8, 2025 20:52
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
hkBst
hkBst reviewed Mar 9, 2025
View reviewed changes
reitermarkus
reitermarkus commented Mar 10, 2025
View reviewed changes
reitermarkus
reitermarkus commented Mar 10, 2025
View reviewed changes
reitermarkus
reitermarkus commented Mar 10, 2025
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reitermarkus reitermarkus requested a review from hkBst March 10, 2025 17:43
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@hkBst
Copy link
Member

hkBst commented Mar 11, 2025 •
edited
Loading 

-        // SAFETY: `self.data.escape_seq` contains an escape sequence, as is 
-        // guaranteed by the caller, and in that case `self.alive` is guaranteed 
+        // SAFETY: `self.data.escape_seq` contains an escape sequence, as is
+        // guaranteed by the caller, and in that case `self.alive` is guaranteed

I'm sure you know this, but if you highlight these lines, you can see that the trailing space is the problem.

@bors
Copy link
Collaborator

bors commented Jun 15, 2025

📌 Commit ce457e1 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2025
@tgross35
Copy link
Contributor

@bors rollup=maybe didn't seem to have any perf impact

tgross35 added a commit to tgross35/rust that referenced this pull request Jun 16, 2025
@tgross35
Rollup merge of rust-lang#138237 - reitermarkus:remove-escape-debug-i…
487a265 
…nner, r=tgross35

Get rid of `EscapeDebugInner`.

I read the note on `EscapeDebugInner` and thought I'd give it a try.
@tgross35 tgross35 mentioned this pull request Jun 16, 2025
Closed
bors added a commit that referenced this pull request Jun 16, 2025
@bors
Auto merge of #142558 - tgross35:rollup-ld8nn4w, r=tgross35
befb020 
Rollup of 7 pull requests

Successful merges:

 - #138237 (Get rid of `EscapeDebugInner`.)
 - #140809 (Reduce special casing for the panic runtime)
 - #141990 (Implement send_signal for unix child processes)
 - #142082 (Refactor `rustc_attr_data_structures` documentation)
 - #142125 (Stabilize "file_lock" feature)
 - #142528 (clarify `rustc_do_not_const_check` comment)
 - #142530 (use `if let` guards where possible)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jun 16, 2025
@bors
Auto merge of #138237 - reitermarkus:remove-escape-debug-inner, r=tgr…
b0eab47 
…oss35

Get rid of `EscapeDebugInner`.

I read the note on `EscapeDebugInner` and thought I'd give it a try.
@bors
Copy link
Collaborator

bors commented Jun 16, 2025

⌛ Testing commit ce457e1 with merge b0eab47...

@bors bors mentioned this pull request Jun 16, 2025
Merged
@rust-log-analyzer
Copy link
Collaborator

The job dist-i586-gnu-i586-i686-musl failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2025
@tgross35
Copy link
Contributor

Seems unrelated?

@bors2 try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors
Copy link

rust-bors bot commented Jun 17, 2025

Unknown value for argument "jobs".

@tgross35
Copy link
Contributor

Should be...
@bors2 try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors
Copy link

rust-bors bot commented Jun 17, 2025

⌛ Trying commit ce457e1 with merge 68d5650…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 17, 2025
@rust-bors
Auto merge of #138237 - reitermarkus:remove-escape-debug-inner, r=<try>
68d5650 
Get rid of `EscapeDebugInner`.

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
<!-- homu-ignore:end -->

I read the note on `EscapeDebugInner` and thought I'd give it a try.
try-job: dist-i586-gnu-i586-i686-musl
@rust-bors
Copy link

rust-bors bot commented Jun 17, 2025

☀️ Try build successful (CI)
Build commit: 68d5650 (68d56507c033370b3289981f6c124b8c4e6917d8, parent: 55d436467c351b56253deeba209ae2553d1c243f)

@tgross35
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Sized Hierarchy: Part I #137944

@bors
Copy link
Collaborator

bors commented Jun 17, 2025

📌 Commit ce457e1 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 18, 2025
@jhpratt
Rollup merge of rust-lang#138237 - reitermarkus:remove-escape-debug-i…
b89fd7c 
…nner, r=tgross35

Get rid of `EscapeDebugInner`.

I read the note on `EscapeDebugInner` and thought I'd give it a try.
@jhpratt jhpratt mentioned this pull request Jun 18, 2025
Closed
bors added a commit that referenced this pull request Jun 18, 2025
@bors
Auto merge of #142656 - jhpratt:rollup-46k4zk0, r=jhpratt
0e33ae2 
Rollup of 10 pull requests

Successful merges:

 - #135656 (Add `-Z hint-mostly-unused` to tell rustc that most of a crate will go unused)
 - #138237 (Get rid of `EscapeDebugInner`.)
 - #140772 ({aarch64,x86_64}-pc-windows-gnullvm: build host tools)
 - #140774 (Affirm `-Cforce-frame-pointers=off` does not override)
 - #141610 (Stabilize `feature(generic_arg_infer)`)
 - #141864 (Handle win32 separator for cygwin paths)
 - #142384 (Bringing `rustc_rayon_core` in tree as `rustc_thread_pool`)
 - #142502 (rustdoc_json: improve handling of generic args)
 - #142571 (Reason about borrowed classes in CopyProp.)
 - #142591 (Add spawn APIs for BootstrapCommand to support deferred command execution)

r? `@ghost`
`@rustbot` modify labels: rollup
Urgau added a commit to Urgau/rust that referenced this pull request Jun 18, 2025
@Urgau
Rollup merge of rust-lang#138237 - reitermarkus:remove-escape-debug-i…
6e2a26e 
…nner, r=tgross35

Get rid of `EscapeDebugInner`.

I read the note on `EscapeDebugInner` and thought I'd give it a try.
@Urgau Urgau mentioned this pull request Jun 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 approved these changes

@hkBst hkBst hkBst left review comments

Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@reitermarkus @rustbot @rust-log-analyzer @hkBst @tgross35 @rust-timer @bors @thomcc