[perf] Decouple directly accessing a HIR owner from ast lowering

[oli-obk]

r? @ghost

cc #95004

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a5a03f3 with merge 6f0ff2d...

[bors]

☀️ Try build successful - checks-actions
Build commit: 6f0ff2d (6f0ff2d14ff131518f6217d8f8353cac6d45382a)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 5671229 with merge 67ad3c3...

[bors]

☀️ Try build successful - checks-actions
Build commit: 67ad3c3 (67ad3c390da18c2f754bac442d61bf79962cebdd)

[rust-timer]

Finished benchmarking commit (6f0ff2d): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 1.3%]	158
Regressions ❌ (secondary)	1.0%	[0.1%, 2.8%]	62
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.1%, 1.3%]	158

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.0%	[0.6%, 17.0%]	10
Regressions ❌ (secondary)	5.7%	[1.3%, 6.6%]	7
Improvements ✅ (primary)	-2.0%	[-2.2%, -1.9%]	3
Improvements ✅ (secondary)	-2.1%	[-3.5%, -0.8%]	8
All ❌✅ (primary)	1.8%	[-2.2%, 17.0%]	13

Cycles

Results (primary 1.5%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.2%, 2.0%]	3
Regressions ❌ (secondary)	2.8%	[1.4%, 3.7%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	1.5%	[1.2%, 2.0%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.901s -> 775.7s (-0.15%)
Artifact size: 365.07 MiB -> 365.12 MiB (0.01%)

[oli-obk]

@rust-timer build 67ad3c3

[rust-timer]

Finished benchmarking commit (67ad3c3): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.2%, 2.5%]	159
Regressions ❌ (secondary)	1.4%	[0.2%, 4.1%]	66
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[0.2%, 2.5%]	159

Max RSS (memory usage)

Results (primary 1.7%, secondary 1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.6%	[0.6%, 17.3%]	8
Regressions ❌ (secondary)	4.4%	[0.8%, 6.4%]	11
Improvements ✅ (primary)	-2.1%	[-2.7%, -1.8%]	4
Improvements ✅ (secondary)	-2.8%	[-3.8%, -1.9%]	6
All ❌✅ (primary)	1.7%	[-2.7%, 17.3%]	12

Cycles

Results (primary 1.6%, secondary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	2.6%	[2.0%, 3.3%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.9%, -1.8%]	4
All ❌✅ (primary)	1.6%	[1.6%, 1.6%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.717s -> 772.179s (-0.20%)
Artifact size: 365.52 MiB -> 365.48 MiB (-0.01%)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 0d1af78 with merge 658a5a6...

[bors]

☀️ Try build successful - checks-actions
Build commit: 658a5a6 (658a5a6a7f12aeb79d54469c023d0c5416731529)

[rust-timer]

Finished benchmarking commit (658a5a6): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.2%, 1.4%]	161
Regressions ❌ (secondary)	1.0%	[0.1%, 2.9%]	64
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.2%, 1.4%]	161

Max RSS (memory usage)

Results (primary 2.1%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[0.7%, 17.3%]	10
Regressions ❌ (secondary)	3.6%	[0.7%, 6.9%]	10
Improvements ✅ (primary)	-2.0%	[-2.3%, -1.8%]	3
Improvements ✅ (secondary)	-2.9%	[-3.5%, -2.2%]	3
All ❌✅ (primary)	2.1%	[-2.3%, 17.3%]	13

Cycles

Results (secondary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.5%, 3.1%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-2.5%, -1.3%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 773.84s -> 775.25s (0.18%)
Artifact size: 365.50 MiB -> 365.51 MiB (0.00%)

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit f9c8be9 with merge 7a639bf...

[bors]

☀️ Try build successful - checks-actions
Build commit: 7a639bf (7a639bfef962a5d3b35a1d0b7a6915f4138dddd0)

[rust-timer]

Finished benchmarking commit (7a639bf): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.1%, 1.3%]	141
Regressions ❌ (secondary)	0.9%	[0.1%, 2.5%]	57
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.1%, 1.3%]	141

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.2%	[0.7%, 15.1%]	9
Regressions ❌ (secondary)	4.5%	[0.7%, 6.3%]	7
Improvements ✅ (primary)	-2.2%	[-2.7%, -1.9%]	3
Improvements ✅ (secondary)	-3.0%	[-4.1%, -1.9%]	5
All ❌✅ (primary)	1.8%	[-2.7%, 15.1%]	12

Cycles

Results (secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.3%, 3.2%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.3%, -1.4%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.297s -> 773.69s (-0.21%)
Artifact size: 365.52 MiB -> 365.51 MiB (-0.00%)