Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache current_dll_path output #138783

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Cache current_dll_path output #138783

merged 1 commit into from
Mar 24, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Mar 21, 2025

Computing the current dll path is somewhat expensive relative to other work when compiling fn main() {} as dladdr needs to iterate over the symbol table of librustc_driver.so until it finds a match.

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3
Cache current_dll_path output
521d0c4 
Computing the current dll path is somewhat expensive relative to other
work when compiling `fn main() {}` as `dladdr` needs to iterate over the
symbol table of librustc_driver.so until it finds a match.
@bjorn3 bjorn3 force-pushed the cache_current_dll_path branch from 715ea3b to 521d0c4 Compare March 21, 2025 12:46
@lqd
Copy link
Member

lqd commented Mar 21, 2025

I don't think we'd need to check rustc-perf here, and if not, this makes sense and looks good, r=me.

@bjorn3
Copy link
Member Author

bjorn3 commented Mar 21, 2025

@bors r=lqd

@bors
Copy link
Contributor

bors commented Mar 21, 2025

📌 Commit 521d0c4 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2025
@jhpratt jhpratt mentioned this pull request Mar 24, 2025
Merged
@bors bors merged commit ab138e6 into rust-lang:master Mar 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 24, 2025
@bjorn3 bjorn3 deleted the cache_current_dll_path branch March 24, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SparrowLii SparrowLii

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.87.0