compiletest: Require //~ annotations even if error-pattern is specified

[petrochenkov]

This is continuation of #138865 with some help from #139100.

error-pattern annotations that duplicate the newly added //~ annotations are removed, other error-patterns are not touched yet.

In exceptional cases //@ compile-flags: --error-format=human can be used to opt out of these checks.
In this PR I only had to use the opt out 3 times:

• tests/ui/parser/utf16-{be,le}-without-bom.rs - there are too many errors that are nearly identical (modulo location), because an error is reported on every second symbol
• tests/ui-fulldeps/missing-rustc-driver-error.rs - the errors list various rustc crate dependencies and may unexpectedly invalidate on random rustc changes

[rustbot]

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

Some changes occurred in src/tools/compiletest

cc @jieyouxu

[jieyouxu]

r? jieyouxu

[jieyouxu]

I'll look at this early tomorrow.

[jieyouxu]

Thanks, changes LGTM. Feel free to r=me after fixing the test conflict.

[jieyouxu]

@bors rollup=never p=10 (merge-conflict prone)

[jieyouxu]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[petrochenkov]

@bors r=jieyouxu

[bors]

📌 Commit ecba3f8 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

💔 Test failed - checks-actions

[petrochenkov]

@bors r=jieyouxu

[bors]

📌 Commit 954d944 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 954d944 with merge faac314...

[bors]

💔 Test failed - checks-actions

[petrochenkov]

@bors r=jieyouxu

[bors]

📌 Commit 4916d44 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4916d44 with merge 946aea0...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 946aea0 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e0883a2 (parent) -> 946aea0 (this PR)

Test differences

No test diffs found

Job duration changes

1. dist-x86_64-apple: 9217.9s -> 11551.6s (25.3%)
2. x86_64-gnu-llvm-19-1: 5365.6s -> 5656.6s (5.4%)
3. aarch64-apple: 3785.4s -> 3972.2s (4.9%)
4. mingw-check: 1266.9s -> 1327.3s (4.8%)
5. dist-x86_64-msvc-alt: 7474.4s -> 7820.1s (4.6%)
6. arm-android: 5451.1s -> 5702.4s (4.6%)
7. dist-aarch64-apple: 4406.4s -> 4599.4s (4.4%)
8. aarch64-gnu-debug: 4062.7s -> 4236.5s (4.3%)
9. i686-gnu-2: 6370.9s -> 6633.7s (4.1%)
10. dist-i686-linux: 5952.3s -> 6179.3s (3.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (946aea0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.5%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.1%	[-2.5%, -1.8%]	2
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.235s -> 776.226s (-0.13%)
Artifact size: 365.89 MiB -> 365.90 MiB (0.00%)