Rollup of 7 pull requests #141437

matthiaskrgr · 2025-05-23T11:34:22Z

Successful merges:

Improve handling of rustdoc lints when used with raw doc fragments. #136400 (Improve handling of rustdoc lints when used with raw doc fragments.)
Async drop poll shim for error dropee generates noop body #140967 (Async drop poll shim for error dropee generates noop body)
Update std doctests for android #141019 (Update std doctests for android)
discuss deadlocks in the std::io::pipe() example #141109 (discuss deadlocks in the std::io::pipe() example)
rustdoc JSON: Don't apply #[repr] privacy heuristics #141126 (rustdoc JSON: Don't apply #[repr] privacy heuristics)
Rename kw::Empty as sym::empty. #141376 (Rename kw::Empty as sym::empty.)
Miri subtree update #141383 (Miri subtree update)

r? @ghost
@rustbot modify labels: rollup

This updates some doctests that fail to run on android. We will soon be supporting cross-compiled doctests, and the `arm-android` job fails to run these tests. In summary: - Android re-exports some traits from linux under a different path. - Android doesn't seem to have common unix utilities like `true`, `false`, or `whoami`, so these are disabled.

Add more comments to libc-fs-with-isolation test

bump rustc-build-sysroot

Automatic Rustup

enable clippy::as_conversions to fully rule out as-casts

run tests on mips-unknown-linux-gnu

…tails we rely on

…ryW-issue GetUserProfileDirectoryW: reference issue regarding implementation details we rely on

Rustup

Automatic Rustup

test direct usage of io::{stdout,stderr,stdin}

FileDescription: improve read/write docs

implement cpuset_getaffinity for freebsd

…-lang#140930)

…851, r=GuillaumeGomez Improve handling of rustdoc lints when used with raw doc fragments. 1. `rustdoc::bare_urls` no longer outputs incoherent suggestions if `source_span_for_markdown_range` returns None, instead outputting no suggestion 2. `source_span_for_markdown_range` has one more heuristic, so it will return `None` less often. 3. add ui test to make sure we don't emit nonsense suggestions. fixes rust-lang#135851

…im-for-error-dropee-fix, r=oli-obk Async drop poll shim for error dropee generates noop body Fixes rust-lang#140930. When dropee type for async drop poll shim is `ty::Error(_)`, the generated poll function will be noop body. To avoid ICE in `elaborate_drop`.

…Mark-Simulacrum Update std doctests for android This updates some doctests that fail to run on android. We will soon be supporting cross-compiled doctests, and the `arm-android` job fails to run these tests. In summary: - Android re-exports some traits from linux under a different path. - Android doesn't seem to have common unix utilities like `true`, `false`, or `whoami`, so these are disabled.

…mulacrum discuss deadlocks in the std::io::pipe() example I think it's important to discuss deadlocks in examples of how to use pipes. The current example does include an explicit `drop()`, but it also implicitly relies on the fact that the `Command` object is temporary, so that it drops its copy of `pong_tx`. This sort of thing tends to trip people up when they use pipes for the first time. I might've gone overboard with the comments in this version, but I'm curious what folks think.

…InTheVoid rustdoc JSON: Don't apply `#[repr]` privacy heuristics Split out from rust-lang#116882. Context: rust-lang#116882 (comment). Partially reverts rust-lang#138018. cc `@obi1kenobi` r? aDotInTheVoid or rustdoc

…rochenkov Rename `kw::Empty` as `sym::empty`. Because the empty string is not a keyword. r? `@petrochenkov`

Miri subtree update r? `@ghost`

matthiaskrgr · 2025-05-23T11:34:32Z

@bors r+ rollup=never p=5

bors · 2025-05-23T11:34:35Z

📌 Commit ee1768c has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-05-23T11:34:36Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors · 2025-05-23T15:13:48Z

⌛ Testing commit ee1768c with merge e88e854...

bors · 2025-05-23T18:21:18Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e88e854 to master...

github-actions · 2025-05-23T18:24:34Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 163cb4e (parent) -> e88e854 (this PR)

Test differences

Show 28 test diffs

Stage 1

[rustdoc-json] tests/rustdoc-json/attrs/repr_transparent.rs: pass -> [missing] (J0)
[ui] tests/rustdoc-ui/lints/bare-urls-limit.rs: [missing] -> pass (J0)
[ui] tests/ui/async-await/async-drop/open-drop-error2.rs: [missing] -> pass (J0)

Stage 2

[rustdoc-json] tests/rustdoc-json/attrs/repr_transparent.rs: pass -> [missing] (J1)
[ui] tests/rustdoc-ui/lints/bare-urls-limit.rs: [missing] -> pass (J1)
[ui] tests/ui/async-await/async-drop/open-drop-error2.rs: [missing] -> pass (J2)

Additionally, 22 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e88e85463468ce5d5ce468414eb69e3b15fa8d42 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5421.2s -> 6893.4s (27.2%)
x86_64-apple-1: 10951.4s -> 9208.3s (-15.9%)
dist-x86_64-apple: 8739.4s -> 9908.2s (13.4%)
dist-i686-linux: 6755.6s -> 6091.4s (-9.8%)
i686-gnu-nopt-1: 9113.2s -> 8259.8s (-9.4%)
dist-aarch64-apple: 6107.0s -> 5543.9s (-9.2%)
mingw-check: 1349.7s -> 1246.2s (-7.7%)
x86_64-rust-for-linux: 2531.8s -> 2709.2s (7.0%)
dist-aarch64-msvc: 8661.0s -> 8145.0s (-6.0%)
x86_64-mingw-1: 8672.6s -> 9129.2s (5.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-05-23T23:30:48Z

Finished benchmarking commit (e88e854): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-0.6%	[-1.4%, -0.2%]	3
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Max RSS (memory usage)

Results (primary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-1.8%, 1.3%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	18
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	18

Bootstrap: 776.992s -> 777.179s (0.02%)
Artifact size: 365.49 MiB -> 365.52 MiB (0.01%)

ehuss and others added 30 commits May 14, 2025 18:26

discuss deadlocks in the std::io::pipe() example

dcef449

Add more comment to libc-fs-with-isolation test

f9a75a0

Merge pull request rust-lang#4322 from tiif/move_test

3c50b9b

Add more comments to libc-fs-with-isolation test

bump rustc-build-sysroot

eb11adc

Merge pull request rust-lang#4330 from RalfJung/build-sysroot-bump

a4eb91f

bump rustc-build-sysroot

Preparing for merge from rustc

b2a8690

Merge from rustc

1bb2d73

Merge pull request rust-lang#4331 from rust-lang/rustup-2025-05-19

d5240cc

Automatic Rustup

enable clippy::as_conversions to fully rule out as-casts

0ba2a3a

add to_u64() helper method and use it where appropriate

446fa22

Merge pull request rust-lang#4329 from RalfJung/no-casts

44d3c93

enable clippy::as_conversions to fully rule out as-casts

run tests on mips-unknown-linux-gnu

aa4d16a

Merge pull request rust-lang#4333 from RalfJung/mips-tests

8d46118

run tests on mips-unknown-linux-gnu

GetUserProfileDirectoryW: reference issue regarding implementation de…

758b799

…tails we rely on

Merge pull request rust-lang#4334 from RalfJung/GetUserProfileDirecto…

26e9172

…ryW-issue GetUserProfileDirectoryW: reference issue regarding implementation details we rely on

Preparing for merge from rustc

969a25b

Merge from rustc

b13251e

Merge pull request rust-lang#4335 from RalfJung/rustup

49482ca

Rustup

Preparing for merge from rustc

293b0ac

Merge from rustc

b5688fb

test direct usage of io::{stdout,stderr,stdin}

2f34354

Merge pull request rust-lang#4336 from rust-lang/rustup-2025-05-21

e12f911

Automatic Rustup

Merge pull request rust-lang#4337 from RalfJung/io

fe51193

test direct usage of io::{stdout,stderr,stdin}

FileDescription: improve read/write docs

0523554

Merge pull request rust-lang#4338 from RalfJung/FileDescription

febe988

FileDescription: improve read/write docs

Implement FreeBSD syscall cpuset_getaffinity.

5dfcb12

Merge pull request rust-lang#4287 from LorrensP-2158466/freebsd-num-cpus

e065e27

implement cpuset_getaffinity for freebsd

run the full test suite under FreeBSD

5955969

document that the entire test suite passes under freebsd

4a18888

fmease and others added 9 commits May 22, 2025 21:26

rustdoc JSON: Don't apply #[repr] privacy heuristics

98bd1a6

Async drop poll shim for error dropee generates noop body (fixes rust…

cb8fdb4

…-lang#140930)

Rollup merge of rust-lang#141376 - nnethercote:rename-kw-Empty, r=pet…

225ed8b

…rochenkov Rename `kw::Empty` as `sym::empty`. Because the empty string is not a keyword. r? `@petrochenkov`

Rollup merge of rust-lang#141383 - RalfJung:miri-sync, r=RalfJung

ee1768c

Miri subtree update r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2025

bors merged commit e88e854 into rust-lang:master May 23, 2025
7 checks passed

rustbot added this to the 1.89.0 milestone May 23, 2025

This was referenced May 23, 2025

[rustdoc] Unify type aliases rendering with other ADT #140863

Merged

GetUserProfileDirectoryW is now documented to always store the size #141405

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #141437

Rollup of 7 pull requests #141437

Uh oh!

matthiaskrgr commented May 23, 2025

Uh oh!

matthiaskrgr commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

Uh oh!

github-actions bot commented May 23, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented May 23, 2025

Uh oh!

Uh oh!

Rollup of 7 pull requests #141437

Rollup of 7 pull requests #141437

Uh oh!

Conversation

matthiaskrgr commented May 23, 2025

Uh oh!

matthiaskrgr commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

Uh oh!

github-actions bot commented May 23, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 23, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!