-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Add autocast support for x86amx
#142251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add autocast support for x86amx
#142251
+1,182
−922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant bitcasts at callsite edit (squash with struct)
- Correct usage of invalid intrinsics in tests
The job Click to see the possible cause of the failure (guessed by this bot)
|
I have decided to split this into different PRs - one for the intrinsic implementation changes, and the AMX changes I will merge with #140763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-run-make
Area: port run-make Makefiles to rmake.rs
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #140763 (well currently it just includes those commits as well) by further adding autocasts for
x86amx
from/to vectors of size 8192 bits.This also disables SIMD vector abi checks for the
"unadjusted"
abi becausex86amx
This PR also does some refactoring in our intrinsic caching mechanism. The core philosophy of this is that the LLVM intrinsic is uniquely determined by its base name and its type parameters (this is only relevant if the intrinsic is not overloaded).
llvm.is.constant
, we could only ever manually cache a finite amount of types, but with this we can now dynamically generate the cache (which also has the byproduct thatis_val_statically_known
is now implemented in cg_llvm for all immediate types.Just putting this as a PR to notify myself that this exists