Rustdoc js: even more typechecking improvements #142270
Open
+42
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-rustdoc-search
|
Some changes occurred in HTML/CSS/JS. |
lolbinarycat
changed the title
This comment has been minimized.
This comment has been minimized.
|
ok, now i've got an error that happens locally but not on CI... what tsc version should I be using anyways? |
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #142644) made this pull request unmergeable. Please resolve the merge conflicts. |
lolbinarycat
force-pushed
the
rustdoc-search-Results-type
branch
from
af9db6e to
b23864d
Compare
| const sortQ = (a, b) => { | ||
| const ag = a.generics.length === 0 && a.bindings.size === 0; | ||
| const bg = b.generics.length === 0 && b.bindings.size === 0; | ||
| if (ag !== bg) { | ||
| // @ts-expect-error | ||
| return ag - bg; | ||
| return +ag - +bg; |
There was a problem hiding this comment.
Please add a comment here and below about the + sign converting the booleans into integers.
|
Just one comment to be added and squashing your commits and then it'll be ready, thanks for the improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some oddities when I went to start working on type aliases, so I've gone and cleaned up a bunch of stuff. Notably
fullIdwas nearly always an integer in practice, but tsc was being told it should be a string.r? @notriddle