Add test cases for namespaced crates #142437
Conversation
rustbot
added
S-waiting-on-review
|
|
||
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be |
There was a problem hiding this comment.
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be | |
| use my_api; |
We should decide the desired behavior before merging this. In this test case, my_api is an open namespace module. I think it makes sense to resolve it, as it's fine to have a module that only contains another module.
There was a problem hiding this comment.
Yeah, this should generally work, unless there are specific reasons for not supporting it (like issues with reexporting things like this to other crates due to them lacking identity).
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api::root_function; | ||
| use my_api::utils::util; |
There was a problem hiding this comment.
This should be an ambiguity error.
my_api::utils refers both to my_api(crate)::utils(mod) and my_api(open_ns)::utils(crate), and they have different definitions.
Alternatively my_api(crate)::utils(mod) will shadow my_api(open_ns)::utils(crate) in the 3-scope model, if we do not report ambiguities even for explicit uses.
There was a problem hiding this comment.
Not sure what you mean, there is no utils(mod) in my_api. The my_api crate only has a public function named root_function.
There was a problem hiding this comment.
Ah, okay, I mixed up tests/ui/resolve/auxiliary/open-ns-my_api.rs and tests/ui/resolve/auxiliary/open-ns-mod-my_api.rs, the files are named too similarly.
I'll need to re-review all the cases.
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api::core::{core_fn, core_fn2}; | ||
| use my_api::utils::*; |
There was a problem hiding this comment.
Also an ambiguity, like in tests/ui/resolve/open-ns-1.rs.
|
|
||
| use my_api::core::{core_fn, core_fn2}; | ||
| use my_api::utils::*; | ||
| use my_api::*; |
There was a problem hiding this comment.
In the 3-scope model this would import from both my_api(crate) and my_api(open_ns).
Therefore it will introduce names utils(mod), root_function and core into this module, but not utils(crate) because it would be shadowed by utils(mod).
Need to test this behavior.
| @@ -0,0 +1,18 @@ | |||
| // This test should fail with `utils` being defined multiple times, since open-ns-mod-my_api.rs | |||
There was a problem hiding this comment.
Hm? There's no open-ns-mod-my_api.rs in this test.
|
|
||
| fn main() { | ||
| let _ = my_api::root_function(); | ||
| let _ = my_api::utils::utils_helper(); |
There was a problem hiding this comment.
Also an ambiguity, like in tests/ui/resolve/open-ns-1.rs.
|
|
||
| //@ ignore-test FIXME(packages_as_namespaces): feature not implemented yet | ||
|
|
||
| use my_api; // FIXME can be resolved even though it (maybe?) shouldn't be |
There was a problem hiding this comment.
Yeah, this should generally work, unless there are specific reasons for not supporting it (like issues with reexporting things like this to other crates due to them lacking identity).
petrochenkov
added
S-waiting-on-author
This is just to add a few test cases of agreed upon desired behavior for this feature so that future PRs can enable them as they start passing.
I pulled these tests out of #140271.
r? @petrochenkov
cc @b-naber