Remove some glob imports from the type system #142637
Open
+259
−208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @WaffleLapkin. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in need_type_info.rs cc @lcnr |
|
☔ The latest upstream changes (presumably #137944) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr
reviewed
Jun 18, 2025
| RegionInferReason::Param(def) => { | ||
| RegionVariableOrigin::RegionParameterDefinition(span, def.name) | ||
| } | ||
| _ => RegionVariableOrigin::MiscVariable(span), |
There was a problem hiding this comment.
given that you're already modifying all uses of this variant, rename it to just Misc in this PR
compiler-errors
force-pushed
the
less-globs
branch
from
032beb8 to
3e35f31
Compare
rustbot
added
the
WG-trait-system-refactor
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor changes to the core type system |
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
less-globs
branch
from
3e35f31 to
9b07e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely, remove the glob imports for
BoundRegionConversionTime,RegionVariableOrigin,SubregionOrigin,TyOrConstInferVar,RegionResolutionError,SelectionError,ProjectionCandidate,ProjectionCandidateSet, and some more specific scoped globs (likeInsertedin the impl overlap graph construction.These glob imports are IMO very low value, since they're not used nearly as often as other globs (like
TyKind).