Skip to content

Skip debug dep node code in non-incremental mode #142686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip debug dep node code in non-incremental mode #142686

wants to merge 1 commit into from
+5 −1

Conversation

zetanumbers
Copy link
Contributor

@zetanumbers zetanumbers commented Jun 18, 2025 •
edited
Loading

Issues happen when trying to use incremental_info with compiler's debug_assertions enabled to access more info, like the "Total Duplicate Edge Reads" counter.

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2025
@lcnr
Copy link
Contributor

lcnr commented Jun 23, 2025

I lack a lot of context to understand these changes. Can you go into more detail for how things are going wrong/what this is fixed

@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@alex-semenyuk
Copy link
Member

@zetanumbers
Thanks for your contribution
From wg-triage. Could you please handle suggestion from comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zetanumbers @rustbot @lcnr @alex-semenyuk