-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Miri subtree update #143137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miri subtree update #143137
Conversation
Automatic Rustup
Automatic Rustup
Apply suggestions from code review Co-authored-by: Oli Scherer <[email protected]> review comments fix possible hang
trace: add barebones ptrace setup
Automatic Rustup
Otherwise there was no way to pass e.g. `--features tracing` just to the `cargo` commands issued on the root repository: CARGO_EXTRA_FLAGS applies the flags to the "cargo-miri" crate, too, which does not make sense for crate-specific features. Fix install_to_sysroot doing path concatenation twice. Since the second concatenation was against an absolute path, it didn't do anything. This also makes the interface of install_to_sysroot() similar to that of cargo_cmd(). Implement --features for clippy, also fix not passing features to one of the cargo invocations for test
Allow building Miri with --features from miri-script
Update src/alloc/isolated_alloc.rs Co-authored-by: Ralf Jung <[email protected]> Update src/alloc/isolated_alloc.rs Co-authored-by: Ralf Jung <[email protected]> Update src/alloc/isolated_alloc.rs Co-authored-by: Ralf Jung <[email protected]> Update src/alloc/isolated_alloc.rs Co-authored-by: Ralf Jung <[email protected]> Update src/alloc/isolated_alloc.rs Co-authored-by: Ralf Jung <[email protected]> address review Apply suggestions from code review Co-authored-by: Ralf Jung <[email protected]> fix comment fix position thing dumb mistake Apply suggestions from code review Co-authored-by: Ralf Jung <[email protected]>
isolated_alloc: directly use mmap for allocations
Automatic Rustup
Co-authored-by: Oli Scherer <[email protected]>
trace: implement supervisor components for tracing
Only write join return value once join succeeds
💔 Test failed
|
I have no idea how that parent.rs file was ever meant to build for other architectures? It seems when the constants and I'm going to disable most of the ptrace machinery to make the build work again -- I don't have the time to figure out how to actually fix the build here. |
@bors2 try jobs=dist-riscv64-linux |
Miri subtree update r? `@ghost` try-job: dist-riscv64-linux
@bors r+ |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry tests\run-make\short-ice spurious failure |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5e749eb (parent) -> ed2d759 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ed2d759783dc9de134bbb3f01085b1e6dbf539f3 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (ed2d759): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 1.2%, secondary 1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 695.323s -> 694.715s (-0.09%) |
r? @ghost