Rollup of 4 pull requests #143183

GuillaumeGomez · 2025-06-29T10:29:57Z

Successful merges:

Add SIMD funnel shift and round-to-even intrinsics #142078 (Add SIMD funnel shift and round-to-even intrinsics)
tests/ui: A New Order [9/N] #142214 (tests/ui: A New Order [9/N])
tests/ui: A New Order [12/N] #142417 (tests/ui: A New Order [12/N])
Fix suggestion spans inside macros for the unused_must_use lint #143030 (Fix suggestion spans inside macros for the unused_must_use lint)

r? @ghost
@rustbot modify labels: rollup

…jubilee Add SIMD funnel shift and round-to-even intrinsics This PR adds 3 new SIMD intrinsics - `simd_funnel_shl` - funnel shift left - `simd_funnel_shr` - funnel shift right - `simd_round_ties_even` (vector version of `round_ties_even_fN`) TODO (future PR): implement `simd_fsh{l,r}` in miri, cg_gcc and cg_clif (it is surprisingly hard to implement without branches, the common tricks that rotate uses doesn't work because we have 2 elements now. e.g, the `-n&31` trick used by cg_gcc to implement rotate doesn't work with this because then `fshl(a, b, 0)` will be `a | b`) [#t-compiler > More SIMD intrinsics](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/More.20SIMD.20intrinsics/with/522130286) `@rustbot` label T-compiler T-libs A-intrinsics F-core_intrinsics r? `@workingjubilee`

`tests/ui`: A New Order [9/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

`tests/ui`: A New Order [12/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@jieyouxu`

Fix suggestion spans inside macros for the `unused_must_use` lint This PR fixes the suggestion spans inside macros for the `unused_must_use` lint by trying to find the oldest ancestor span. Fixes rust-lang#143025

GuillaumeGomez · 2025-06-29T10:30:10Z

@bors r+p=5 rollup=never

jieyouxu · 2025-06-29T11:37:13Z

(Missing a space :D)

@bors r=GuillaumeGomez p=5 rollup=never

bors · 2025-06-29T11:37:16Z

📌 Commit f9f3935 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-06-29T13:02:18Z

⌛ Testing commit f9f3935 with merge 5e749eb...

bors · 2025-06-29T16:02:58Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 5e749eb to master...

rust-timer · 2025-06-29T16:04:09Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#142078	Add SIMD funnel shift and round-to-even intrinsics	`9cc8723267ce2737aaacebc888e07d56dfeb6f1e` (link)
#142214	`tests/ui`: A New Order [9/N]	`5447f1ef952088b6842817524929d79446f53716` (link)
#142417	`tests/ui`: A New Order [12/N]	`2530fdc76300f2c6a6fc8a529def9c3871eee61a` (link)
#143030	Fix suggestion spans inside macros for the `unused_must_use…	`c4174acdbfa8fd2eb14102af3f1c4837aea2c77d` (link)

previous master: 5ca574e85b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-06-29T16:06:01Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5ca574e (parent) -> 5e749eb (this PR)

Test differences

Show 70 test diffs

Stage 1

[ui] tests/ui/allocator/empty-alloc-nonnull-guarantee.rs: [missing] -> pass (J1)
[ui] tests/ui/associated-types/unconstrained-lifetime-assoc-type.rs: [missing] -> pass (J1)
[ui] tests/ui/attributes/inline-attribute-enum-variant-error.rs: [missing] -> pass (J1)
[ui] tests/ui/attributes/inline-main.rs: [missing] -> pass (J1)
[ui] tests/ui/diverging-fn-tail-35849.rs: pass -> [missing] (J1)
[ui] tests/ui/double-ref.rs: pass -> [missing] (J1)
[ui] tests/ui/double-type-import.rs: pass -> [missing] (J1)
[ui] tests/ui/early-ret-binop-add.rs: pass -> [missing] (J1)
[ui] tests/ui/elide-errors-on-mismatched-tuple.rs: pass -> [missing] (J1)
[ui] tests/ui/elided-test.rs: pass -> [missing] (J1)
[ui] tests/ui/else-if.rs: pass -> [missing] (J1)
[ui] tests/ui/empty-allocation-non-null.rs: pass -> [missing] (J1)
[ui] tests/ui/expr/early-return-in-binop.rs: [missing] -> pass (J1)
[ui] tests/ui/generics/unconstrained-type-params-inherent-impl.rs: [missing] -> pass (J1)
[ui] tests/ui/impl-unused-rps-in-assoc-type.rs: pass -> [missing] (J1)
[ui] tests/ui/impl-unused-tps-inherent.rs: pass -> [missing] (J1)
[ui] tests/ui/impl-unused-tps.rs: pass -> [missing] (J1)
[ui] tests/ui/implicit-method-bind.rs: pass -> [missing] (J1)
[ui] tests/ui/imports/duplicate-use-bindings.rs: [missing] -> pass (J1)
[ui] tests/ui/inline-disallow-on-variant.rs: pass -> [missing] (J1)
[ui] tests/ui/inlined-main.rs: pass -> [missing] (J1)
[ui] tests/ui/lint/unused/must-use-macros.rs: [missing] -> pass (J1)
[ui] tests/ui/methods/method-missing-call.rs: pass -> [missing] (J1)
[ui] tests/ui/methods/method-value-without-call.rs: [missing] -> pass (J1)
[ui] tests/ui/mismatched_types/elide-on-tuple-mismatch.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/reference-whitespace-parsing.rs: [missing] -> pass (J1)
[ui] tests/ui/test-attrs/test-function-elided-no-main.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/constrained-type-params-trait-impl.rs: [missing] -> pass (J1)
[ui] tests/ui/transmute/diverging-fn-transmute.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/allocator/empty-alloc-nonnull-guarantee.rs: [missing] -> pass (J0)
[ui] tests/ui/associated-types/unconstrained-lifetime-assoc-type.rs: [missing] -> pass (J0)
[ui] tests/ui/attributes/inline-attribute-enum-variant-error.rs: [missing] -> pass (J0)
[ui] tests/ui/attributes/inline-main.rs: [missing] -> pass (J0)
[ui] tests/ui/diverging-fn-tail-35849.rs: pass -> [missing] (J0)
[ui] tests/ui/double-ref.rs: pass -> [missing] (J0)
[ui] tests/ui/double-type-import.rs: pass -> [missing] (J0)
[ui] tests/ui/early-ret-binop-add.rs: pass -> [missing] (J0)
[ui] tests/ui/elide-errors-on-mismatched-tuple.rs: pass -> [missing] (J0)
[ui] tests/ui/elided-test.rs: pass -> [missing] (J0)
[ui] tests/ui/else-if.rs: pass -> [missing] (J0)
[ui] tests/ui/empty-allocation-non-null.rs: pass -> [missing] (J0)
[ui] tests/ui/expr/early-return-in-binop.rs: [missing] -> pass (J0)
[ui] tests/ui/generics/unconstrained-type-params-inherent-impl.rs: [missing] -> pass (J0)
[ui] tests/ui/impl-unused-rps-in-assoc-type.rs: pass -> [missing] (J0)
[ui] tests/ui/impl-unused-tps-inherent.rs: pass -> [missing] (J0)
[ui] tests/ui/impl-unused-tps.rs: pass -> [missing] (J0)
[ui] tests/ui/implicit-method-bind.rs: pass -> [missing] (J0)
[ui] tests/ui/imports/duplicate-use-bindings.rs: [missing] -> pass (J0)
[ui] tests/ui/inline-disallow-on-variant.rs: pass -> [missing] (J0)
[ui] tests/ui/inlined-main.rs: pass -> [missing] (J0)
[ui] tests/ui/lint/unused/must-use-macros.rs: [missing] -> pass (J0)
[ui] tests/ui/methods/method-missing-call.rs: pass -> [missing] (J0)
[ui] tests/ui/methods/method-value-without-call.rs: [missing] -> pass (J0)
[ui] tests/ui/mismatched_types/elide-on-tuple-mismatch.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/reference-whitespace-parsing.rs: [missing] -> pass (J0)
[ui] tests/ui/test-attrs/test-function-elided-no-main.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/constrained-type-params-trait-impl.rs: [missing] -> pass (J0)
[ui] tests/ui/transmute/diverging-fn-transmute.rs: [missing] -> pass (J0)

Additionally, 12 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5e749eb66f93ee998145399fbdde337e57cd72ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5639.8s -> 7474.8s (32.5%)
x86_64-apple-1: 8427.5s -> 6796.5s (-19.4%)
dist-aarch64-apple: 5724.7s -> 4864.9s (-15.0%)
i686-gnu-2: 6133.2s -> 6680.3s (8.9%)
aarch64-apple: 4753.5s -> 4334.3s (-8.8%)
dist-ohos-armv7: 3727.7s -> 4037.4s (8.3%)
dist-x86_64-apple: 9840.5s -> 9088.7s (-7.6%)
armhf-gnu: 4869.6s -> 5229.0s (7.4%)
x86_64-gnu: 6948.3s -> 7369.0s (6.1%)
dist-armv7-linux: 4728.7s -> 4996.0s (5.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-29T17:29:12Z

Finished benchmarking commit (5e749eb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.8%	[-3.8%, -3.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.8%	[-3.8%, -3.8%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 695.013s -> 695.323s (0.04%)
Artifact size: 371.77 MiB -> 371.80 MiB (0.01%)

sayantn and others added 10 commits June 15, 2025 04:33

Add simd_funnel_sh{l,r} and simd_round_ties_even

2038405

Implement simd_round_ties_even for miri, cg_clif and cg_gcc

2ffa1dd

Fix suggestion spans inside macros for the unused_must_use lint

05d3d17

Bless tests/ui/macros/must-use-in-macro-55516.rs

3175fb2

cleaned up some tests

aac948b

cleaned up some tests

f4502b8

Rollup merge of rust-lang#142214 - Kivooeo:tf9, r=jieyouxu

15b227f

`tests/ui`: A New Order [9/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895.

Rollup merge of rust-lang#142417 - Kivooeo:tf12, r=jieyouxu

05b209d

`tests/ui`: A New Order [12/N] Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang#133895. r? `@jieyouxu`

Rollup merge of rust-lang#143030 - Urgau:issue-143025, r=SparrowLii

f9f3935

Fix suggestion spans inside macros for the `unused_must_use` lint This PR fixes the suggestion spans inside macros for the `unused_must_use` lint by trying to find the oldest ancestor span. Fixes rust-lang#143025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025

bors merged commit 5e749eb into rust-lang:master Jun 29, 2025
1 check passed

rustbot added this to the 1.90.0 milestone Jun 29, 2025

GuillaumeGomez deleted the rollup-g60lr91 branch June 29, 2025 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #143183

Rollup of 4 pull requests #143183

Uh oh!

GuillaumeGomez commented Jun 29, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Jun 29, 2025

Uh oh!

jieyouxu commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

Uh oh!

Rollup of 4 pull requests #143183

Rollup of 4 pull requests #143183

Uh oh!

Conversation

GuillaumeGomez commented Jun 29, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 29, 2025

Uh oh!

jieyouxu commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

bors commented Jun 29, 2025

Uh oh!

Uh oh!

rust-timer commented Jun 29, 2025

Uh oh!

github-actions bot commented Jun 29, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jun 29, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

GuillaumeGomez commented Jun 29, 2025 •

edited by rustbot

Loading