Stop passing resolver disambiguator state to AST lowering. #143361
+46
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
PG-exploit-mitigations
cjgillot
commented
Jul 3, 2025
| @@ -872,7 +872,8 @@ impl<'tcx> Printer<'tcx> for SymbolMangler<'tcx> { | |||
| DefPathData::ValueNs(_) => 'v', | |||
| DefPathData::Closure => 'C', | |||
| DefPathData::Ctor => 'c', | |||
| DefPathData::AnonConst => 'k', | |||
| DefPathData::AnonConst => 'K', | |||
| DefPathData::LateAnonConst => 'k', | |||
There was a problem hiding this comment.
I'm not certain changing mangling is the best idea. Is there some update to a demangler to be made before this PR is accepted?
There was a problem hiding this comment.
I'm surprised you're not getting the demangler roundtrip ICE, but most likely this code path isn't hit in codegen tests with v0 mangling.
I don't think it's possible without changing mangling
|
@rustbot author Please add a codegen test (which will probably ICE if the compiler is built with debug assertions as the demangler can't support this new syntax yet). |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AST->HIR lowering can use a disjoint set of
DefPathDataas the resolver, so we don't need to pass the disambiguator state.r? @oli-obk