Streamline config parsing method #144301
Open
Streamline config parsing method #144301
+752
−713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
Shourya742
force-pushed
the
2025-06-22-move-build-toml-parsing-to-build-config
branch
from
e1a4d2a to
db3b43d
Compare
|
Can be rebased now. |
|
☔ The latest upstream changes (presumably #144294) made this pull request unmergeable. Please resolve the merge conflicts. |
1. Moves TOML build parsing into a separate module. 2. Corrects the ordering of `apply_*_config` method calls. 3. Moves download logic specific to `toml_config` into its own module. 4. Updates tests to align with the correct behavior.
Shourya742
force-pushed
the
2025-06-22-move-build-toml-parsing-to-build-config
branch
from
db3b43d to
121be5a
Compare
|
I went through this and seeing how the code is structured now helped me realize some issues with how we currently parse Config. I did some experiments based on your branch and I'd like to propose a slightly different structuring here. We can discuss it during our next call. |
|
☔ The latest upstream changes (presumably #144360) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rustbot blocked On refactoring download methods. |
rustbot
added
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after: #144126 (as this PR contains few of it commits )
This PR streamlines the parse_inner function of the config:
r? @Kobzol