Skip to content

Unify LLVM ctlz/cttz intrinsic generation #144455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

Unify LLVM ctlz/cttz intrinsic generation #144455

merged 1 commit into from
Jul 27, 2025
+9 −19

Conversation

TDecking
Copy link
Contributor

The type signature for llvm.ctlz is the same as the one for llvm.cttz, which enables a small simplification.

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 25, 2025
@SparrowLii
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 26, 2025

📌 Commit 948c795 has been approved by SparrowLii

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 27, 2025
Merged
bors added a commit that referenced this pull request Jul 27, 2025
@bors
Auto merge of #144528 - matthiaskrgr:rollup-felcjc1, r=matthiaskrgr
eed187c 
Rollup of 4 pull requests

Successful merges:

 - #144226 (Do not assert layout in KnownPanicsLint.)
 - #144385 (Optimize performance by inline in macro hygiene system)
 - #144454 (move uefi test to run-make)
 - #144455 (Unify LLVM ctlz/cttz intrinsic generation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dd6e4a9 into rust-lang:master Jul 27, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jul 27, 2025
@rust-timer
Unrolled build for #144455
506c507 
Rollup merge of #144455 - TDecking:ctlz-cttz, r=SparrowLii

Unify LLVM ctlz/cttz intrinsic generation

The type signature for `llvm.ctlz` is the same as the one for `llvm.cttz`, which enables a small simplification.
@rustbot rustbot added this to the 1.90.0 milestone Jul 27, 2025
@TDecking TDecking deleted the ctlz-cttz branch July 27, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SparrowLii SparrowLii SparrowLii approved these changes

Assignees

@SparrowLii SparrowLii

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TDecking @rustbot @SparrowLii @bors