-
Notifications
You must be signed in to change notification settings - Fork 13.6k
miri subtree update #144570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miri subtree update #144570
Conversation
Automatic Rustup
non-deterministically truncate reads/writes
Automatic Rustup
CI: add windows-arm runner
Use `josh-sync` instead of `miri-script` for Josh synchronization
make the missing-MIR message more clear
This updates the rust-version file to b56aaec.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: b56aaec Filtered ref: 12f5e3255df658296af9fc953d8c1ab79ba91ea3 This merge was created using https://github.com/rust-lang/josh-sync.
Fix cronjob Zulip message
Perfetto gives an error if an id does not fit in an 64-bit signed integer in 2's complement.
Automatic Rustup
Miscellaneous fixes for tracing
This comment has been minimized.
This comment has been minimized.
@Patrick-6 You said we need cc 1.2.30, but that's not correct, is it? And it seems we could easily avoid it by just calling |
Wait sorry, you meant that the |
@jieyouxu that's what I thought the comment meant. I guess it means something else. |
I have updated the comment. @jieyouxu can we just rely on PR CI catching these |
cc = "=1.2.16" | ||
# `cc` updates often break things, so we pin it here. Cargo enforces "max 1 semver-compat version | ||
# per crate", so if you change this, you need to also change it in `rustc_llvm`. | ||
cc = "=1.2.30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we could just remove the pin here and rely on rustc_llvm
pinning the version for the entire workspace... 🤷
I think it's easiest to just try full CI |
The Another reason why |
@bors r+ rollup=never |
miri subtree update Subtree update of `miri` to rust-lang/miri@5ff8417. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Yeah that looks like a |
cc dependencies: clarify comment This caused confusion in rust-lang#144570 r? `@jieyouxu`
cc dependencies: clarify comment This caused confusion in rust-lang#144570 r? ``@jieyouxu``
Subtree update of
miri
to rust-lang/miri@5ff8417.Created using https://github.com/rust-lang/josh-sync.
r? @ghost