Rollup of 33 pull requests #145588

jhpratt · 2025-08-18T21:42:22Z

Successful merges:

Extend QueryStability to handle IntoIterator implementations #139345 (Extend QueryStability to handle IntoIterator implementations)
Add -Zindirect-branch-cs-prefix #140740 (Add -Zindirect-branch-cs-prefix)
nll-relate: improve hr opaque types support #142079 (nll-relate: improve hr opaque types support)
implement std::fs::set_permissions_nofollow on unix #142938 (implement std::fs::set_permissions_nofollow on unix)
Correct some grammar in integer documentation #144767 (Correct some grammar in integer documentation)
Require approval from t-infra instead of t-release on tier bumps #144906 (Require approval from t-infra instead of t-release on tier bumps)
Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144983 (Rehome 37 tests/ui/issues/ tests to other subdirectories under tests/ui/)
run spellcheck as a tidy extra check in ci #145025 (run spellcheck as a tidy extra check in ci)
suggest using pub(crate) for E0364 #145166 (suggest using pub(crate) for E0364)
dec2flt: Provide more valid inputs examples #145255 (dec2flt: Provide more valid inputs examples)
Add tracing to various miscellaneous functions #145306 (Add tracing to various miscellaneous functions)
Hide docs for core::unicode #145336 (Hide docs for core::unicode)
Couple of codegen_fn_attrs improvements #145429 (Couple of codegen_fn_attrs improvements)
Do not strip binaries in bootstrap everytime if they are unchanged #145452 (Do not strip binaries in bootstrap everytime if they are unchanged)
Stabilize const_pathbuf_osstring_new feature #145464 (Stabilize const_pathbuf_osstring_new feature)
Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups)
Fix unicode_data.rs mention message #145486 (Fix unicode_data.rs mention message)
remove should_render in PrintAttribute derive #145493 (remove should_render in PrintAttribute derive)
Simplify span caches #145505 (Simplify span caches)
Visit and print async_fut local for async drop. #145510 (Visit and print async_fut local for async drop.)
Rust build fails on OpenBSD after using file_lock feature #145511 (Rust build fails on OpenBSD after using file_lock feature)
resolve: debug for block module #145532 (resolve: debug for block module)
Reorder lto options from most to least optimizing #145533 (Reorder lto options from most to least optimizing)
Do not consider a T: !Sized candidate to satisfy a T: !MetaSized obligation. #145537 (Do not consider a T: !Sized candidate to satisfy a T: !MetaSized obligation.)
bufreader::Buffer::backshift: don't move the uninit bytes #145538 (bufreader::Buffer::backshift: don't move the uninit bytes)
triagebot: Don't warn no-mentions on subtree updates #145542 (triagebot: Don't warn no-mentions on subtree updates)
Update rust maintainers in openharmony.md #145549 (Update rust maintainers in openharmony.md)
Avoid using () in derive(From) output. #145550 (Avoid using () in derive(From) output.)
Allow stability attributes on extern crates #145556 (Allow stability attributes on extern crates)
Remove unused PartialOrd/Ord from bootstrap #145560 (Remove unused PartialOrd/Ord from bootstrap)
ignore frontmatters in TokenStream::new #145568 (ignore frontmatters in TokenStream::new)
remove myself from some adhoc-groups and pings #145571 (remove myself from some adhoc-groups and pings)
Add change tracker entry for --timings #145576 (Add change tracker entry for --timings)

r? @ghost
@rustbot modify labels: rollup

Update "between" to "among" (more than two items), connect the "which" dependent clause to the independent part, and remove the redundant "here".

I was just looking at the specifics of how the parsing is handled here and I wasn't sure if the examples were incomplete or the grammar below was misleading. The grammar was correct so I figured I'd add these examples to clarify.

Fix adjacent code Fix duplicate warning; merge test into `tests/ui-fulldeps/internal-lints` Use `rustc_middle::ty::FnSig::inputs` Address two review comments - rust-lang#139345 (comment) - rust-lang#139345 (comment) Use `Instance::try_resolve` Import `rustc_middle::ty::Ty` as `Ty` rather than `MiddleTy` Simplify predicate handling Add more `#[allow(rustc::potential_query_instability)]` following rebase Remove two `#[allow(rustc::potential_query_instability)]` following rebase Address review comment Update compiler/rustc_lint/src/internal.rs Co-authored-by: lcnr <[email protected]>

PR 130999 added the file_lock feature, but doesn't included OpenBSD in the supported targets (Tier 3 platform), leading to a compilation error ("try_lock() not supported").

jhpratt · 2025-08-18T21:42:50Z

Let's do a try build due to the enormous size.

@bors2 try

rust-bors · 2025-08-18T21:42:54Z

⌛ Trying commit 271430e with merge fbca531…

To cancel the try build, run the command @bors try cancel.

Rollup of 33 pull requests

Kobzol · 2025-08-18T22:21:33Z

Note that the default try build doesn't run any tests and doesn't actually build much stuff, apart from what would already get built on PR CI.

jhpratt · 2025-08-18T22:22:40Z

In that case, @bors2 try cancel

What should be run instead?

rust-bors · 2025-08-18T22:22:43Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/17053256218

jhpratt · 2025-08-18T22:27:17Z

After discussion on Zulip,

@bors r+ rollup=never p=5

bors · 2025-08-18T22:27:20Z

📌 Commit 271430e has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-08-19T02:30:17Z

⌛ Testing commit 271430e with merge 35f6640...

Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-08-19T04:21:41Z

💔 Test failed - checks-actions

Zalathar · 2025-08-19T04:26:42Z

GitHub is once again refusing to show useful logs, so I'm going to assume that the GHA runners exploded again.

@bors retry

jhpratt · 2025-08-19T04:28:50Z

Looks like either msvc or mingw failed, judging from the status icons alone. Given that I agree it's reasonable to retry.

tgross35 · 2025-08-19T07:08:32Z

GitHub is once again refusing to show useful logs, so I'm going to assume that the GHA runners exploded again.

For the failed job, click the "annotations" dropdown to see this (indeed it was spurious)

Zalathar · 2025-08-19T08:16:07Z

Bors hasn't noticed that this PR now has conflicts with #145589.

@bors r-

tgross35 and others added 30 commits July 31, 2025 22:53

Correct some grammar in integer documentation

ad61b31

Update "between" to "among" (more than two items), connect the "which" dependent clause to the independent part, and remove the redundant "here".

Require approval from t-infra instead of t-release on tier bumps

d85a645

dec2flt: Provide more valid inputs examples

fb04c5e

I was just looking at the specifics of how the parsing is handled here and I wasn't sure if the examples were incomplete or the grammar below was misleading. The grammar was correct so I figured I'd add these examples to clarify.

Make a James Bond reference

2f796d9

suggest using pub(crate) for E0364

0c8485f

Hide docs for core::unicode

c855a2f

All weak lang items have an explicit link name and vice versa

4d62bf1

Combining no_mangle and rustc_std_internal_symbol is not allowed

f3ef465

Merge link_name and export_name

460519a

Remove unused feature gate

f94a0d0

Do not strip binaries in bootstrap everytime if they are unchanged

ef3bb6f

stabilize const pathbuf osstring new

b79ab44

Properly recover from parenthesized use-bounds (precise capturing)

eb3e0d4

Fix unicode_data.rs mention message

e906a59

remove should_render in PrintAttribute derive

3450975

Clean up parsers related to generic bounds

f8f7c27

run spellcheck as a tidy extra check in ci

e31fed0

Simplify decode_span.

6c15339

Simplify span_data_to_lines_and_cols.

a843730

Visit and print async_fut local for async drop.

f35d001

tidy now installs typos-cli as-needed via cargo

1cb4fd7

tidy: run typos check in src root, not current dir

6a51eef

tidy: add better error reporting for if typos can't be run

d73e6b4

typos: allow moreso

0d797d2

std: fix more typos

2050a3b

Rust build fails on OpenBSD after using file_lock feature

8792010

PR 130999 added the file_lock feature, but doesn't included OpenBSD in the supported targets (Tier 3 platform), leading to a compilation error ("try_lock() not supported").

Add //@ ignore-stage1 to query_stability.rs test

3b0ff9c

resolve: debug for block module

9878616

Add -Zindirect-branch-cs-prefix (from draft PR)

1cd7080

rustbot added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Aug 18, 2025

rust-bors bot added a commit that referenced this pull request Aug 18, 2025

Auto merge of #145588 - jhpratt:rollup-gfojsgp, r=<try>

fbca531

Rollup of 33 pull requests

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025

Zalathar mentioned this pull request Aug 19, 2025

Rollup of 19 pull requests #145589

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2025

jieyouxu closed this Aug 19, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 19, 2025

jhpratt deleted the rollup-gfojsgp branch August 19, 2025 13:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 33 pull requests #145588

Rollup of 33 pull requests #145588

Uh oh!

jhpratt commented Aug 18, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

rust-bors bot commented Aug 18, 2025

Uh oh!

Kobzol commented Aug 18, 2025

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

rust-bors bot commented Aug 18, 2025

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

bors commented Aug 19, 2025

Uh oh!

bors commented Aug 19, 2025

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

jhpratt commented Aug 19, 2025

Uh oh!

tgross35 commented Aug 19, 2025

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Uh oh!

Rollup of 33 pull requests #145588

Rollup of 33 pull requests #145588

Uh oh!

Conversation

jhpratt commented Aug 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

rust-bors bot commented Aug 18, 2025

Uh oh!

Kobzol commented Aug 18, 2025

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

rust-bors bot commented Aug 18, 2025

Uh oh!

jhpratt commented Aug 18, 2025

Uh oh!

bors commented Aug 18, 2025

Uh oh!

bors commented Aug 19, 2025

Uh oh!

bors commented Aug 19, 2025

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

jhpratt commented Aug 19, 2025

Uh oh!

tgross35 commented Aug 19, 2025

Uh oh!

Zalathar commented Aug 19, 2025

Uh oh!

Uh oh!

jhpratt commented Aug 18, 2025 •

edited by rustbot

Loading