Skip to content

str: Stabilize round_char_boundary feature #145756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

str: Stabilize round_char_boundary feature #145756

wants to merge 1 commit into from
+22 −26

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Aug 22, 2025

Closes #93743
FCP completed #93743 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@okaneco okaneco mentioned this pull request Aug 22, 2025
Open
5 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
samueltardieu
samueltardieu reviewed Aug 22, 2025
View reviewed changes
compiler/rustc_middle/src/lib.rs
@@ -51,7 +51,6 @@
#![feature(negative_impls)]
#![feature(never_type)]
#![feature(ptr_alignment_type)]
#![feature(round_char_boundary)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't you need to cfg_attr(bootstrap, …) the feature in the compiler itself (two instances)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to do this in Clippy's clippy_lints crate as well, since it can now be built by the stage0 compiler.

Copy link
Contributor Author

@okaneco okaneco Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I haven't stabilized a feature that touched these other parts of the compiler before.

I manually reordered the cfg_attr features because tidy check complained about alphabetic ordering, but it didn't suggest what line to place it. I couldn't find an automatic --fix option either. Running ./x fmt didn't seem to adjust it either but maybe I have the setup configured wrong (I have it set to the library contributing mode, not sure if that changes anything).

Copy link
Member

@samueltardieu samueltardieu Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x fmt doesn't reorder AFAICT, you have to put the inner attributes in order by hand (as you did).

Clippy using stage 0 is new and doesn't care about inner attributes order, what you did (order by feature name) is fine as well there.

samueltardieu
samueltardieu reviewed Aug 22, 2025
View reviewed changes
src/tools/clippy/tests/ui/char_indices_as_byte_indices.rs
@@ -1,4 +1,3 @@
#![feature(round_char_boundary)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run ./x.py test clippy --bless to update the stderr file with the line number changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in c5c6520

@okaneco okaneco force-pushed the stabilize_char_boundary branch from 214dcea to c5c6520 Compare August 22, 2025 17:26
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@okaneco okaneco force-pushed the stabilize_char_boundary branch from c5c6520 to e42c1b1 Compare August 22, 2025 17:43
@samueltardieu
Copy link
Member

@bors try

rust-bors bot added a commit that referenced this pull request Aug 26, 2025
@rust-bors
Auto merge of #145756 - okaneco:stabilize_char_boundary, r=<try>
ed7a7c9 
str: Stabilize `round_char_boundary` feature
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Aug 26, 2025

☀️ Try build successful (CI)
Build commit: ed7a7c9 (ed7a7c96cbb2c4e90c5e0f498edca4a3e026991b, parent: 91ee6a4057ce4bf1ab6d2f932cae497488d67c81)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@scottmcm scottmcm

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for str::{floor, ceil}_char_boundary
5 participants
@okaneco @rustbot @rust-log-analyzer @samueltardieu @scottmcm