test(rustfmt): Verify frontmatter is preserved #145766
Open
+48
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prove that the frontmatter is preserved. The choices in tests is intended for showing the different parts of the proposed Style Guide for frontmatters.
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
| --- | ||
| #![feature(frontmatter)] | ||
|
|
||
| fn main() {} |
There was a problem hiding this comment.
Should this check that the file as a whole is being formatted? I think rustfmt sometimes bails out on formatting just from the presence somewhere in the file of syntax... not sure if that's happening here or not (or quite what the test format here looks like).
It probably makes sense to try to get rustfmt team review (do you have someone to re-assign already?). Otherwise, if we think that's not feasible, happy to just rubberstamp.
|
Probably worth rolling a rustfmt reviewer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to prove that the frontmatter is preserved.
The choices in tests is intended for showing the different parts of the proposed Style Guide for frontmatters (#145617).
While rustfmt is developed in a different repo, work involving upstream integration is blocked on some work that is being finished up in that repo. I was told that it would be ok to post against this repo in the mean time.
Tracking issue: #136889