rustdoc: [PoC] [WIP] Don't render keyword Self as SelfTy
#145806
Draft
+201
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
T-rustdoc
rustbot
added
A-attributes
fmease
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really dirty mockup, somewhat broken, too. Inspired by this Reddit post.
Of course, there would be a much simpler quite obvious fix of just hardcoding the Self|->SelfTy mapping. I'm trying to avoid that right now because that'd be really unprincipled. Anyways, let's see how my current approach fares or if I'll push myself to fix the overarching letter casing issue once and forall instead.
Fixes #98828.