Rollup of 5 pull requests #145949

jhpratt · 2025-08-28T01:51:55Z

Successful merges:

Add assembly test for -Zreg-struct-return option #145382 (Add assembly test for -Zreg-struct-return option)
Fix STD build failing for target_os = "espidf" #145746 (Fix STD build failing for target_os = "espidf")
Use AcceptContext in AttribueParser::check_target #145826 (Use AcceptContext in AttribueParser::check_target)
Ensure the coordinator thread terminates before its channels drop #145894 (Ensure the coordinator thread terminates before its channels drop)
Remove unnecessary [dependencies.*] entries. #145946 (Remove unnecessary [dependencies.unicode-properties] entries.)

r? @ghost
@rustbot modify labels: rollup

…n` for structs of different sizes. This test covers: * The callee side, making sure that the structs are correctly loaded into registers when `-Zreg-struct-return` is enabled * The caller side, making sure that callers do receive returned structs in registers when `-Zreg-struct-return` is enabled Structs of the size of up to 2 registers (8 bytes) can be returned in registers in x86_32. Therefore, the tests are done with 3 different struct sizes: * 2 bytes (register returns should happen) * 8 bytes (last value where register returns should happen) * 12 bytes (register returns should not happen even when `-Zreg-struct-return` is enabled)

The Cargo style guide says to put dependencies on a single line if they fit.

…test, r=tgross35 Add assembly test for `-Zreg-struct-return` option r? `@tgross35` As discussed in rust-lang#145309 with `@tgross35` and `@ojeda,` I added assembly tests for the `-Zreg-struct-return` option verifying that it changes the ABI from hidden pointer to register-return on x86_32. The test covers: - Direct struct construction, showing register return vs hidden pointer - External function calls returning structs, showing ABI mismatch handling Different memory layouts affect ABI mismatch handling, but register returns use the same register allocation regardless of struct field layout (apart from the fact that they use smaller registers for smaller structs, of course). [Here](https://godbolt.org/z/dcW6rnMG3) is a compiler explorer with 2 examples. Let me know if there is anything more I could add. Since register returns only happen for structs up to the size of 2 registers, I figured testing the pivot value (8 bytes) would be most critical.

…raheemdev Fix STD build failing for target_os = "espidf" A regression from rust-lang#142938 cc `@lolbinarycat` cc `@ibraheemdev` ESP-IDF (and a few other embedded Tier-3 systems) is considered `cfg(unix)`, but it does not have the `O_NOFOLLOW` flag because neither of its three supported filesystems (FATFS, LitteLF and Spiffs) has symbolic links in the first place. What this fix does is to keep the `set_permissions_nofollow` method available and non-failing for ESP-IDF, but it behaves as if no `O_NONFOLLOW` was set. This should be fine as there is nothing to follow in the first place, as there are no symbolic links there. EDIT: Also added the same fix for Horizon, as requested by `@Meziu.`

…szelmann Use AcceptContext in AttribueParser::check_target

…Lapkin Ensure the coordinator thread terminates before its channels drop Fixes rust-lang#142949 Explanation: rust-lang#142949 (comment)

…lmann Remove unnecessary `[dependencies.unicode-properties]` entries. The Cargo style guide says to put dependencies on a single line if they fit. r? `@jdonszelmann`

jhpratt · 2025-08-28T01:52:06Z

@bors r+ rollup=never p=5

bors · 2025-08-28T01:52:09Z

📌 Commit 27d6005 has been approved by jhpratt

It is now in the queue for this repository.

bors · 2025-08-28T03:06:55Z

⌛ Testing commit 27d6005 with merge 43a2166...

bors · 2025-08-28T06:13:15Z

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 43a2166 to master...

rust-timer · 2025-08-28T06:14:42Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#145382	Add assembly test for `-Zreg-struct-return` option	`4bb89c4a93e5b09694c053f11c92a6ff07e66c44` (link)
#145746	Fix STD build failing for target_os = "espidf"	`bc7a1b7c86cd3418af82eb60f8392b62dd87e282` (link)
#145826	Use AcceptContext in AttribueParser::check_target	`b5513cbd9ed4dc5bc806b5d848c729ebcf1c8768` (link)
#145894	Ensure the coordinator thread terminates before its channel…	`6d6191d5a5f0a9f4e23f6a9bb5eb943db0ec67ad` (link)
#145946	Remove unnecessary `[dependencies.unicode-properties]` entr…	`678166b96dd8cbf687e07b2f281c55c7dcc9f65f` (link)

previous master: d36f964125

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-08-28T06:16:27Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d36f964 (parent) -> 43a2166 (this PR)

Test differences

Show 4 test diffs

Stage 1

[assembly] tests/assembly-llvm/reg-struct-return.rs#WITH: [missing] -> pass (J1)
[assembly] tests/assembly-llvm/reg-struct-return.rs#WITHOUT: [missing] -> pass (J1)

Stage 2

[assembly] tests/assembly-llvm/reg-struct-return.rs#WITH: [missing] -> pass (J0)
[assembly] tests/assembly-llvm/reg-struct-return.rs#WITHOUT: [missing] -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 43a216604a7fc98deb0744513341fc0d09e461d4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1695.3s -> 1405.0s (-17.1%)
x86_64-gnu-llvm-19: 2887.1s -> 2412.5s (-16.4%)
aarch64-apple: 6816.4s -> 6003.2s (-11.9%)
i686-gnu-2: 6353.9s -> 5686.9s (-10.5%)
arm-android: 6742.0s -> 6048.6s (-10.3%)
dist-aarch64-msvc: 5380.8s -> 5904.1s (9.7%)
dist-aarch64-apple: 7330.2s -> 6636.2s (-9.5%)
dist-i686-mingw: 8604.1s -> 9255.4s (7.6%)
x86_64-gnu-aux: 6625.1s -> 7056.0s (6.5%)
x86_64-gnu-llvm-20-1: 3615.3s -> 3388.3s (-6.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-28T07:23:45Z

Finished benchmarking commit (43a2166): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.2%, 2.3%]	2
Regressions ❌ (secondary)	1.7%	[1.4%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.2%, 2.3%]	2

Cycles

Results (primary 2.1%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.595s -> 468.052s (-0.33%)
Artifact size: 390.67 MiB -> 390.65 MiB (-0.01%)

ivmarkov and others added 11 commits August 23, 2025 12:32

Fix STD build failing for target_os = espidf

6e5a427

Ensure the coordinator thread terminates first

82cc0ee

Comment on intentional field order

dd07459

Use AcceptContext in AttribueParser::check_target

2736c74

Remove unnecessary [dependencies.unicode-properties] entries.

b4c8fe2

The Cargo style guide says to put dependencies on a single line if they fit.

Rollup merge of rust-lang#145826 - scrabsha:push-vrpwttmzqwpt, r=jdon…

64d0d1d

…szelmann Use AcceptContext in AttribueParser::check_target

Rollup merge of rust-lang#145894 - zetanumbers:issue-142949, r=Waffle…

5527156

…Lapkin Ensure the coordinator thread terminates before its channels drop Fixes rust-lang#142949 Explanation: rust-lang#142949 (comment)

Rollup merge of rust-lang#145946 - nnethercote:cargo-style, r=jdonsze…

27d6005

…lmann Remove unnecessary `[dependencies.unicode-properties]` entries. The Cargo style guide says to put dependencies on a single line if they fit. r? `@jdonszelmann`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2025

bors merged commit 43a2166 into rust-lang:master Aug 28, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 28, 2025

jhpratt deleted the rollup-smzd7tr branch August 28, 2025 06:24

bors mentioned this pull request Aug 28, 2025

Add more to the [workspace.dependencies] section in the top-level Cargo.toml #145947

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #145949

Rollup of 5 pull requests #145949

Uh oh!

jhpratt commented Aug 28, 2025 •

edited by rustbot

Loading

Uh oh!

jhpratt commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 28, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #145949

Rollup of 5 pull requests #145949

Uh oh!

Conversation

jhpratt commented Aug 28, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

bors commented Aug 28, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 28, 2025

Uh oh!

github-actions bot commented Aug 28, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 28, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

jhpratt commented Aug 28, 2025 •

edited by rustbot

Loading