minimal dirfd implementation (1/4) #146341

Qelxiros · 2025-09-08T17:32:07Z

This is the first of four smaller PRs that will eventually be equivalent to #139514.

A few notes:

I renamed new to open because open_dir takes &self and opens a subdirectory.
- I also renamed open to open_file.
I'm not sure how to impl AsRawFd and friends because the common implementation uses PathBufs. How should I proceed here?

The other PRs will be based on this one, so I'll make drafts and mark them ready as their predecessors get merged. They might take a bit though; I've never done this particular thing with git before.

Tracking issue: #120426

r? @tgross35

try-job: aarch64-apple
try-job: dist-various*
try-job: test-various*
try-job: x86_64-msvc-1
try-job: x86_64-mingw*

library/std/src/sys/fs/common.rs

library/std/src/sys/fs/uefi.rs

library/std/src/sys/fs/unsupported.rs

library/std/src/fs.rs

library/std/src/sys/fs/windows.rs

tgross35 · 2025-09-10T03:01:20Z

@ChrisDenton I'll need your help for the Windows review

library/std/src/sys/fs/unix.rs

Qelxiros · 2025-09-10T17:19:09Z

@rustbot ready

tgross35

Looks pretty good to me, just a few mechanical things here. There are a couple left over from the previous review, #146341 (comment), #146341 (comment), and (newly) #146341 (comment).

View changes since this review

library/std/src/sys/fs/unix/dir.rs

library/std/src/sys/fs/unsupported.rs

library/std/src/sys/fs/unix.rs

library/std/src/sys/fs/windows.rs

library/std/src/sys/fs/unix.rs

library/std/src/sys/fs/windows/dir.rs

tgross35 · 2025-09-10T21:19:14Z

library/std/src/sys/fs/windows/dir.rs

+    let mut handle = ptr::null_mut();
+    let mut io_status = c::IO_STATUS_BLOCK::PENDING;
+    let access = opts.get_access_mode()? | c::SYNCHRONIZE;
+    let options = create_options | c::FILE_SYNCHRONOUS_IO_NONALERT;


Could you add a note about why this flag is set?

I no longer remember why I chose this one, and looking at it now, I'm not sure whether we should set this one, FILE_SYNCHRONOUS_IO_ALERT, or neither. Maybe @ChrisDenton has thoughts?

tgross35 · 2025-09-10T21:24:27Z

From the top post:

* I'm not sure how to `impl AsRawFd` and friends because the `common` implementation uses `PathBuf`s. How should I proceed here?

I think it would be fine to include the impl AsRawFd only in unix/dir so it's only implemented if we have dirfd. I'll add an unresolved question to the tracking issue.

The other PRs will be based on this one, so I'll make drafts and mark them ready as their predecessors get merged. They might take a bit though; I've never done this particular thing with git before.

That is quite alright, there is no hurry :) For reference, the --update-refs rebase flag can be pretty useful when you're working with a stack (e.g. https://andrewlock.net/working-with-stacked-branches-in-git-is-easier-with-update-refs/)

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

tgross35 · 2025-09-11T03:43:03Z

@bors2 try

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

rust-bors · 2025-09-11T04:22:54Z

💔 Test for ba4037e failed: CI. Failed jobs:

try - dist-various-2 (web logs, extended logs)

tgross35 · 2025-09-11T04:44:24Z

library/std/src/fs/tests.rs

@@ -1,5 +1,6 @@
 use rand::RngCore;

+use super::Dir;


This needs a gate on miri to not be unused

tgross35 · 2025-09-11T16:27:13Z

@bors2 try

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

rust-bors · 2025-09-11T17:07:31Z

💔 Test for 26d8112 failed: CI. Failed jobs:

try - dist-various-2 (web logs, extended logs)

tgross35 · 2025-09-11T18:56:52Z

@bors2 try

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

rust-log-analyzer · 2025-09-11T21:02:20Z

The job x86_64-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- fs::tests::test_dir_read_file stdout ----

thread 'fs::tests::test_dir_read_file' (5072) panicked at library\std\src\fs\tests.rs:2251:17:
dir.open_file("foo.txt") failed with: The parameter is incorrect. (os error 87)
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: <std::ffi::os_str::Display as core::fmt::Debug>::fmt
   3: test::convert_benchmarks_to_tests
---

error: test failed, to rerun pass `-p std --lib`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 1:57:06
make: *** [Makefile:112: ci-msvc-py] Error 1
  local time: Thu Sep 11 21:02:03 CUT 2025
  network time: Thu, 11 Sep 2025 21:02:03 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

rust-bors · 2025-09-11T21:02:57Z

💔 Test for d36ef83 failed: CI. Failed jobs:

try - x86_64-msvc-1 (web logs, extended logs)

rustbot assigned tgross35 Sep 8, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 8, 2025

Qelxiros force-pushed the dirfd-minimum branch from c3278f6 to 6982a46 Compare September 8, 2025 17:37

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 6982a46 to 313c731 Compare September 8, 2025 18:26

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 313c731 to 1b3d7d6 Compare September 8, 2025 18:55

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 1b3d7d6 to be0d761 Compare September 9, 2025 15:09

tgross35 requested changes Sep 10, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

tgross35 requested a review from ChrisDenton September 10, 2025 03:01

Qelxiros force-pushed the dirfd-minimum branch from be0d761 to 3083d58 Compare September 10, 2025 17:17

Qelxiros commented Sep 10, 2025

View reviewed changes

library/std/src/sys/fs/unix.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025

tgross35 reviewed Sep 10, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 10, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

0ac54d6

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 10, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

ba649e4

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 3083d58 to 7b0f5ce Compare September 11, 2025 01:30

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 7b0f5ce to 20bd04e Compare September 11, 2025 02:09

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 11, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

ba4037e

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

This comment has been minimized.

Sign in to view

tgross35 reviewed Sep 11, 2025

View reviewed changes

library/std/src/fs/tests.rs

@@ -1,5 +1,6 @@

use rand::RngCore;

use super::Dir;

Copy link

Contributor

tgross35 Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a gate on miri to not be unused

Qelxiros force-pushed the dirfd-minimum branch from 20bd04e to 73435f8 Compare September 11, 2025 15:17

rust-bors bot added a commit that referenced this pull request Sep 11, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

26d8112

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 73435f8 to 1f8f886 Compare September 11, 2025 17:11

Add Dir::open(_file) and some trait impls

109188b

Qelxiros force-pushed the dirfd-minimum branch from 1f8f886 to 109188b Compare September 11, 2025 17:15

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 11, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

d36ef83

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

minimal dirfd implementation (1/4) #146341

Are you sure you want to change the base?

minimal dirfd implementation (1/4) #146341

Conversation

Qelxiros commented Sep 8, 2025 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Sep 10, 2025

Uh oh!

Uh oh!

Qelxiros commented Sep 10, 2025

Uh oh!

tgross35 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

Qelxiros Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment has been minimized.

tgross35 commented Sep 11, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 11, 2025

Uh oh!

tgross35 Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Sep 11, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 11, 2025

Uh oh!

tgross35 commented Sep 11, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Sep 11, 2025

Uh oh!

rust-bors bot commented Sep 11, 2025

Uh oh!

Uh oh!

Qelxiros commented Sep 8, 2025 •

edited by tgross35

Loading

tgross35 left a comment •

edited

Loading