Skip to content

Rollup of 2 pull requests #150563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 4 commits into from
Jan 1, 2026
Merged

Rollup of 2 pull requests #150563

bors merged 4 commits into from
Jan 1, 2026

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Jan 1, 2026 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tiif and others added 4 commits December 30, 2025 10:16
@tiif
Move c-variadic arguments handling into compute_inputs_and_output
791fa37
@rustbot @ehuss
Update books
a3d8291
@JonathanBrouwer
Rollup merge of rust-lang#150454 - tiif:move_variadic, r=oli-obk
36457ce 
cleanup: move c-variadic arguments handling into compute_inputs_and_output

Previously, ``unnormalized_input_tys`` needs to be mutable because the c_variadic arguments are added to ``unnormalized_input_tys`` outside of ``compute_inputs_and_output``. This could have been done together in ``compute_inputs_and_output``.
@JonathanBrouwer
Rollup merge of rust-lang#150529 - rustbot:docs-update, r=ehuss
cef03a7 
Update books

## rust-lang/reference

21 commits in ec78de0ffe2f8344bd0e222b17ac7a7d32dc7a26..6363385ac4ebe1763f1e6fb2063c0b1db681a072
2025-12-15 16:17:43 +0000 to 2025-12-31 21:12:35 +0000
- Remove cargo workspace inheritance (rust-lang/reference#2129)
- identifiers: bump Unicode from 16 to 17 (rust-lang/reference#2071)
- Fix alternation order of lexical rules (rust-lang/reference#2126)
- Fix overly greedy digits (rust-lang/reference#2124)
- Clarify UNICODE_ESCAPE valid token value (rust-lang/reference#2123)
- Fix ambiguity of RESERVED_RAW_IDENTIFIER (rust-lang/reference#2122)
- Document how closure capturing interacts with discriminant reads (rust-lang/reference#1837)
- operator-expr: remove stray word in footnote (rust-lang/reference#2118)
- await-expr: add a missing space (rust-lang/reference#2120)
- attributes: add missing punctuation to instruction_set (rust-lang/reference#2117)
- associated-items: add missing periods (rust-lang/reference#2116)
- Move tools into a consolidated cargo workspace (rust-lang/reference#2115)
- Unwrap all of the lexical chapters (rust-lang/reference#2113)
- Unwrap const_eval.md (rust-lang/reference#2112)
- Add section on expansion-time (early) name resolution (rust-lang/reference#2055)
- const_eval.md: add missing word (rust-lang/reference#2068)
- path-expr.md: use a more suitable punctuation (rust-lang/reference#2082)
- items: clarify label for type-aliases documentation (rust-lang/reference#2110)
- do not mix singular and plural (rust-lang/reference#2101)
- external-blocks: add missing "and" in list (rust-lang/reference#2111)
- conditional-compilation: add a space in `cfg.cfg_attr.attribute-list` (rust-lang/reference#2109)

## rust-lang/rust-by-example

2 commits in 7d21279e40e8f0e91c2a22c5148dd2d745aef8b6..2e02f22a10e7eeb758e6aba484f13d0f1988a3e5
2025-12-21 08:47:57 UTC to 2025-12-21 08:46:33 UTC

- docs(comments): improve readability and formatting (rust-lang/rust-by-example#1981)
- Fix HOF.MD sum of odd squares algorithm (rust-lang/rust-by-example#1980)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Jan 1, 2026

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jan 1, 2026

📌 Commit cef03a7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors
Copy link
Collaborator

bors commented Jan 1, 2026

⌛ Testing commit cef03a7 with merge cc08b55...

@bors
Copy link
Collaborator

bors commented Jan 1, 2026

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing cc08b55 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors bors merged commit cc08b55 into rust-lang:main Jan 1, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 1, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150454 cleanup: move c-variadic arguments handling into compute_in… 3c87aab64d4bd70e77eb24264bd0dd886bc02b06 (link)
#150529 Update books dbb40f4d1c0cedc18df7c362b4bad1c2436d47ae (link)

previous master: b49c7d784e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b49c7d7 (parent) -> cc08b55 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cc08b553b899821331ddbfb970e243a7dd0957a3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 8920.4s -> 10365.9s (+16.2%)
  2. dist-x86_64-apple: 6279.4s -> 7072.6s (+12.6%)
  3. dist-x86_64-solaris: 5412.0s -> 6037.9s (+11.6%)
  4. dist-loongarch64-linux: 5935.9s -> 5265.8s (-11.3%)
  5. dist-arm-linux-musl: 5483.1s -> 6015.1s (+9.7%)
  6. aarch64-gnu: 6966.8s -> 7562.4s (+8.5%)
  7. x86_64-msvc-ext2: 5541.9s -> 5955.8s (+7.5%)
  8. x86_64-gnu-gcc: 2881.3s -> 3091.7s (+7.3%)
  9. tidy: 166.1s -> 155.0s (-6.7%)
  10. x86_64-msvc-ext3: 6107.9s -> 6467.2s (+5.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Jan 1, 2026

Finished benchmarking commit (cc08b55): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.9% [4.4%, 5.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -6.9%, secondary -12.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [1.6%, 2.6%] 2
Regressions ❌
(secondary)		 5.2% [4.3%, 6.2%] 2
Improvements ✅
(primary)		 -8.9% [-12.7%, -3.5%] 9
Improvements ✅
(secondary)		 -14.9% [-25.3%, -2.6%] 12
All ❌✅ (primary) -6.9% [-12.7%, 2.6%] 11

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.873s -> 475.256s (-0.34%)
Artifact size: 390.81 MiB -> 390.83 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @bors @rust-timer @rustbot @tiif