Rollup of 11 pull requests #150839

matthiaskrgr · 2026-01-08T21:21:22Z

Successful merges:

tidy: add if-installed prefix condition to extra checks system #149961 (tidy: add if-installed prefix condition to extra checks system)
std: sys: fs: uefi: Implement initial File #150475 (std: sys: fs: uefi: Implement initial File)
std: sys: fs: uefi: Implement remove_dir_all #150533 (std: sys: fs: uefi: Implement remove_dir_all)
fix missing_panics_doc in std::os::fd::owned #150549 (fix missing_panics_doc in std::os::fd::owned)
MGCA: Support literals as direct const arguments #150699 (MGCA: Support literals as direct const arguments)
Deprecated doc intra link #150721 (Deprecated doc intra link)
Minor cleanups to fn_abi_new_uncached #150802 (Minor cleanups to fn_abi_new_uncached)
compiler-builtins subtree update #150803 (compiler-builtins subtree update)
Update literal-escaper version to 0.0.7 #150809 (Update literal-escaper version to 0.0.7)
Store defids instead of symbol names in the aliases list #150811 (Store defids instead of symbol names in the aliases list)
Query associated_item_def_ids when needed #150825 (Query associated_item_def_ids when needed)

Define a new function ensure_version which is extracted (and modified) from ensure_version_or_cargo_install.

for other extra checks, it is WIP.

This updates the rust-version file to 23d01cd.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 23d01cd Filtered ref: 5d28c73d267214190903896b4caf2e40a17a56cb Upstream diff: rust-lang/rust@2dc3024...23d01cd This merge was created using https://github.com/rust-lang/josh-sync.

…emove unsafe from usages" We can't drop the `unsafe` here because it is required at the `libm` MSRV. Instead, we will need to `allow` the lint. This reverts commit 96ac3624abc144db930d94504a9c67aad7b949ed.

- Implement basic opening and creating files. - Also implement debug. Signed-off-by: Ayush Singh <[email protected]>

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

Make it easier to run the same steps outside of GitHub Actions.

- Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. Signed-off-by: Ayush Singh <[email protected]>

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it. CC rust-lang#150725

This commit moves a query to `associated_item_defs` from above an error condition caused independently of it to below it. It looks generally cleaner and might potentially save some runtime in case the error condition is met, rendering `items` to be left unused, yet still queried.

…k, r=lolbinarycat tidy: add if-installed prefix condition to extra checks system Ref: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/543227610 tidy now runs spellcheck (typos-cli) without adding `--extra-checks=spellcheck` option if the tool is already installed under ./build/misc-tools and the version is expected. It will improve code quality without bothering engineers who doesn't want to use typos or who cleans up ./build directory frequently.

@rustbot

std: sys: fs: uefi: Implement initial File - Implement basic opening and creating files. - Also implement debug. @rustbot label +O-UEFI

@rustbot

std: sys: fs: uefi: Implement remove_dir_all - Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. @rustbot label +O-UEFI

matthiaskrgr · 2026-01-08T21:21:48Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-08T21:21:53Z

📌 Commit 0fbcfb9 has been approved by matthiaskrgr

It is now in the queue for this repository.

matthiaskrgr · 2026-01-08T21:22:42Z

@bors try=dist-ohos-x86_64

rust-bors · 2026-01-08T21:22:44Z

Unknown command "try". Run @bors help to see available commands.

matthiaskrgr · 2026-01-08T21:25:05Z

@bors try jobs=dist-ohos-x86_64

Rollup of 11 pull requests try-job: dist-ohos-x86_64

rust-bors · 2026-01-08T22:56:22Z

☀️ Try build successful (CI)
Build commit: 9514167 (95141672033f684896e74f20e9e460873175cb5f, parent: 4586feb998521343b91c554adbb11ba30547d67a)

rust-bors · 2026-01-09T03:02:57Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Pushing 3fda0e4 to main...

github-actions · 2026-01-09T03:05:39Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 31cd367 (parent) -> 3fda0e4 (this PR)

Test differences

Show 42 test diffs

Stage 0

extra_checks::tests::test_extra_check_arg_from_str_err: [missing] -> pass (J1)
extra_checks::tests::test_extra_check_arg_from_str_ok: [missing] -> pass (J1)

Stage 1

[rustdoc-html] tests/rustdoc-html/intra-doc/deprecated.rs: [missing] -> pass (J0)
[ui] tests/rustdoc-ui/intra-doc/deprecated.rs: [missing] -> pass (J0)

Stage 2

[rustdoc-html] tests/rustdoc-html/intra-doc/deprecated.rs: [missing] -> pass (J2)
[ui] tests/rustdoc-ui/intra-doc/deprecated.rs: [missing] -> pass (J2)

Additionally, 36 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3fda0e426ca17b0baa0d6e765a0d23f487350573 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 3474.1s -> 4285.9s (+23.4%)
aarch64-gnu-llvm-20-1: 3634.2s -> 3242.8s (-10.8%)
tidy: 163.0s -> 180.2s (+10.5%)
aarch64-msvc-1: 7449.6s -> 6730.9s (-9.6%)
pr-check-1: 1690.2s -> 1529.9s (-9.5%)
x86_64-msvc-ext1: 7173.1s -> 7817.1s (+9.0%)
dist-aarch64-llvm-mingw: 6355.9s -> 5828.7s (-8.3%)
i686-gnu-nopt-1: 7283.3s -> 7836.7s (+7.6%)
dist-various-1: 4327.0s -> 4058.9s (-6.2%)
dist-android: 1666.9s -> 1570.1s (-5.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-09T03:06:04Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149961	tidy: add if-installed prefix condition to extra checks sys…	`e62844f11c5cd48b02bc9bfff6f6bd5b6d0a640c` (link)
#150475	std: sys: fs: uefi: Implement initial File	`f01fea837cbf089608da2a66fbb65712528f2c6c` (link)
#150533	std: sys: fs: uefi: Implement remove_dir_all	`9c530a25800cba51d9fa77613c4684e628fe734a` (link)
#150549	fix missing_panics_doc in `std::os::fd::owned`	`ca47f13b4ece969d36279051648d93d9effa9c2c` (link)
#150699	MGCA: Support literals as direct const arguments	`7dcb568a5ab87f090341fed0ad6ce6482c4e6b1d` (link)
#150721	Deprecated doc intra link	`8afa5b41773a6088f83d4f30be70c5f16d78b684` (link)
#150802	Minor cleanups to fn_abi_new_uncached	`fcd63d1b95ce9350135a7b85d1068de995238602` (link)
#150803	compiler-builtins subtree update	`4db46f073a3fd2e072fdb1716675f595224b031c` (link)
#150809	Update `literal-escaper` version to `0.0.7`	`6bc87d796dedf402fcd44b5f72eeafb1958c2e8d` (link)
#150811	Store defids instead of symbol names in the aliases list	`54eb8dbe0702f41959bdd5667d809a9242e2acc4` (link)
#150825	Query associated_item_def_ids when needed	`58fc491af55543793ba2e6fe955ded1b828d1197` (link)

previous master: 31cd367b9c

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-01-09T03:46:02Z

Finished benchmarking commit (3fda0e4): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Cycles

Results (primary 0.1%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.3%	[-3.0%, -1.5%]	3
All ❌✅ (primary)	0.1%	[-2.3%, 2.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.812s -> 474.629s (-0.04%)
Artifact size: 390.90 MiB -> 390.98 MiB (0.02%)

Shunpoco and others added 30 commits December 25, 2025 12:15

Extract version check from ensure_version_or_cargo_install

9f7dc2e

Define a new function ensure_version which is extracted (and modified) from ensure_version_or_cargo_install.

implpement if_installed for spellcheck

b305a98

for other extra checks, it is WIP.

implement shellcheck

70d8c61

implement js check

258708f

implement py and cpp

5642a2d

Prepare for merging from rust-lang/rust

6da3605

This updates the rust-version file to 23d01cd.

compiler-builtins: Revert "cpuid is safe since the stdarch sync, so r…

380e4d2

…emove unsafe from usages" We can't drop the `unsafe` here because it is required at the `libm` MSRV. Instead, we will need to `allow` the lint. This reverts commit 96ac3624abc144db930d94504a9c67aad7b949ed.

Ignore unused_unsafe lint in libm/src/math/arch/x86/detect.rs

1276564

std: sys: fs: uefi: Implement initial File

2ac2b18

- Implement basic opening and creating files. - Also implement debug. Signed-off-by: Ayush Singh <[email protected]>

fix typo (this commit will be squashed after review)

b49e56d

fix missing_panics_doc in std::os::fd::owned

215768a

https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

address review

68ea14a

Fix a typo in libm::Libm::roundeven

0d366e0

ci: Move the dependency installs and wall time benchmarks to scripts

65639fe

Make it easier to run the same steps outside of GitHub Actions.

add unit test for ExtraCheckArg::from_str

08e0400

move ensure_version/ensure_version_or_cargo_install to extra_checks

dfe7d8a

std: sys: fs: uefi: Implement remove_dir_all

3f773fa

- Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. Signed-off-by: Ayush Singh <[email protected]>

address reviews

0dfff23

compiler-builtins: Enable AArch64 __chkstk for MinGW

69bedd1

Similarly to i686 and X86_64 MinGW targets, Rust needs to provide the right chkstk symbol for AArch64 to avoid relying on the linker to provide it. CC rust-lang#150725

make MarkdownItemInfo a field struct

64c78f6

render intra-doc links in the #[deprectated] note

3be74a7

Minor cleanups to fn_abi_new_uncached

aec8b69

Update literal-escaper version to 0.0.7

27b1083

store defids instead of symbol names in the aliases list

6b88c6b

MGCA: literals support

9f3956f

Rollup merge of rust-lang#150475 - uefi-fs-file, r=ChrisDenton

d217707

std: sys: fs: uefi: Implement initial File - Implement basic opening and creating files. - Also implement debug. @rustbot label +O-UEFI

Rollup merge of rust-lang#150533 - uefi-fs-rmdirall, r=ChrisDenton

836ff9c

std: sys: fs: uefi: Implement remove_dir_all - Using the implementation from sys::fs::common since UEFI does not have a built-in for this functionality. @rustbot label +O-UEFI

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jan 8, 2026

Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=<try>

9514167

Rollup of 11 pull requests try-job: dist-ohos-x86_64

This comment has been minimized.

Sign in to view

rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2026

rust-bors bot merged commit 3fda0e4 into rust-lang:main Jan 9, 2026
13 checks passed

rustbot added this to the 1.94.0 milestone Jan 9, 2026

rust-bors bot mentioned this pull request Jan 9, 2026

Clippy subtree update #150818

Merged

This was referenced Jan 9, 2026

Add field representing types #146307

Open

[Experiment] Do not emit noalias for some functions including .as_mut_ptr() #146823

Open

Uh oh!

Rollup of 11 pull requests #150839

Rollup of 11 pull requests #150839

Uh oh!

Conversation

matthiaskrgr commented Jan 8, 2026

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

rust-bors bot commented Jan 8, 2026

Uh oh!

matthiaskrgr commented Jan 8, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 8, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 9, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 9, 2026

Uh oh!

rust-timer commented Jan 9, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants