Rollup of 10 pull requests #150860
Closed
Rollup of 10 pull requests #150860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`find()` has a missing example. In the docs there was a mention of an example with double reference but it didn't exist. `rfind()` is also very similar to `find()`, however it had the double reference example and no owned value example like `find()` did. This commit adds the missing examples and making them look consistent.
Change the `SmallVec` size from 4 to 1, because that's sufficient in the vast majority of cases. (This doesn't affect performance in practice, so it's more of a code clarity change than a performance change.)
…t args
Detect the `{ident?}` pattern where `?` is immediately followed by `}` and emit
a clearer diagnostic explaining that `:` is required for Debug formatting.
This avoids falling back to a generic “invalid format string” error and adds
a targeted UI test for the case.
Signed-off-by: Usman Akinyemi <[email protected]>
…acro_transparency`
…imulacrum Use realstd current thread static variables in tests Fixes rust-lang#150053. This PR basically exports `thread::current::CURRENT` & `thread::current::ID*` static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred as `readlstd::...` in `test_internals` module. If approved, i would kindly ask this PR to be beta nominated. Thank you.
…tmcm docs(core): update `find()` and `rfind()` examples [find()](https://doc.rust-lang.org/std/iter/trait.Iterator.html) has a missing example. In the docs there is mention of an example with double reference but it doesn't exist. <img width="1476" height="1229" alt="image" src="https://github.com/user-attachments/assets/b99062ed-3a47-4b87-8e0c-58afd7de1332" /> [rfind()](https://doc.rust-lang.org/core/iter/trait.DoubleEndedIterator.html#method.rfind) is also very similar to `find()`, however it has the double reference example and no owned value example like `find()` does. <img width="1473" height="1163" alt="image" src="https://github.com/user-attachments/assets/7977ae5c-9888-4513-8dfc-a7c03c7ef072" /> This commit adds the missing examples and making them look consistent.
adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file this adds the `Ordering` enum to `minicore.rs`. consequently, this updates `tests/assembly-llvm/rust-abi-arg-attr.rs` to import `minicore` directly. previously, this test file contained traits like `Copy` `Clone` `PointeeSized`, which were giving a duplicate lang item error, so replace those by importing `minicore` completely.
Finish transition from `semitransparent` to `semiopaque` for `rustc_macro_transparency` Since it's a bit annoying to have different names for the same thing. My understanding is that this is just internal stuff that is not part of any public API even tough rust-analyzer knows about it. Continuation of - rust-lang#139084. Discovered while investigating - rust-lang#150514
Clarify `MoveData::init_loc_map`. Change the `SmallVec` size from 4 to 1, because that's sufficient in the vast majority of cases. (This doesn't affect performance in practice, so it's more of a code clarity change than a performance change.) r? @cjgillot
mgca: Type-check fields of struct expr const args Fixes rust-lang#150623. Fixes rust-lang#150712. Fixes rust-lang#150714. Fixes rust-lang#150734. r? @BoxyUwU
Use functions more in rustdoc GUI tests Now that conditions are supported in `browser-ui-test`, we can start simplify some parts of the tests. This is a first cleanup, but I guess a lot more could be simplified. For follow-ups I guess. :) I made some improvements in backtrace display in `browser-ui-test`, hence the version update once more. r? @lolbinarycat
rustc_parse_format: improve error for missing `:` before `?` in format args
Detect the `{ident?}` pattern where `?` is immediately followed by `}` and emit a clearer diagnostic explaining that `:` is required for Debug formatting. This avoids falling back to a generic “invalid format string” error and adds a targeted UI test for the case.
Fix trait method anchor disappearing before user can click on it A good example of this bug is going to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/collect/struct.ItemCtxt.html#impl-HirTyLowerer%3C'tcx%3E-for-ItemCtxt%3C'tcx%3E, and then try to click on the `§` anchor of the `tcx` method. The solution to this bug is to simply "glue" the anchor to the method, so when the mouse cursor moves to it, there is no gap between the two, preventing the anchor to disappear (hopefully this explanation doesn't make sense only to me ^^'). First commit fixes the bug by expanding the anchor size. Second commit is a small clean-up of the GUI test. Third commit actually adds the GUI regression test. cc @BoxyUwU r? @camelid
tests/ui/borrowck/issue-92157.rs: Remove (bug not fixed) The bug the test tests for is masked by the wrong `#[lang = "start"]` signature. If the signature is corrected, the test builds. But that is not because the bug is fixed, but because the test has been changed too much from the original reproducer. The original reproducer still ICE:s. See rust-lang#92157 (comment). But that's fine since in the latest compiler says: > note: using internal features is not supported and expected to cause internal compiler errors when used incorrectly So let's remove the test and close the issue as "won't fix". See rust-lang#92157 (comment). r? @JohnTitor since you added the test in rust-lang#106878
rustbot
added
A-attributes
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
rust-bors
bot
added
S-waiting-on-bors
Contributor
Contributor
|
🔒 Merge conflict This pull request and the base branch diverged in a way that cannot How do I rebase?Assuming
You may also read Please avoid the "Resolve conflicts" button on GitHub. Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how |
rustbot
added
the
S-waiting-on-review
Member
Author
|
@bors r+ |
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
find()andrfind()examples #150272 (docs(core): updatefind()andrfind()examples)semitransparenttosemiopaqueforrustc_macro_transparency#150561 (Finish transition fromsemitransparenttosemiopaqueforrustc_macro_transparency)MoveData::init_loc_map. #150574 (ClarifyMoveData::init_loc_map.):before?in format args #150765 (rustc_parse_format: improve error for missing:before?in format args)r? @ghost
Create a similar rollup