Rollup of 14 pull requests #150924

JonathanBrouwer · 2026-01-10T12:06:24Z

Successful merges:

Reflection MVP #146923 (Reflection MVP)
Implement create_dir_all() to operate iteratively instead of recursively #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file)
Fix dso_local for external statics with linkage #150494 ( Fix dso_local for external statics with linkage)
Unix implementation for stdio set/take/replace #150668 (Unix implementation for stdio set/take/replace)
mGCA: Support array expression as direct const arguments #150786 (mGCA: Support array expression as direct const arguments)
THIR patterns: Replace AscribeUserType and ExpandedConstant wrappers with per-node data #150788 (THIR patterns: Replace AscribeUserType and ExpandedConstant wrappers with per-node data)
Fix ICE: can't type-check body of DefId for issue #148729 #150799 (Fix ICE: can't type-check body of DefId for issue ICE: can't type-check body of DefId #148729)
Remove std_detect_file_io and std_detect_dlsym_getauxval features #150804 (Remove std_detect_file_io and std_detect_dlsym_getauxval features)
std: sys: fs: uefi: Implement File::write #150852 (std: sys: fs: uefi: Implement File::write)
std: sys: fs: uefi: Implement File::flush #150862 (std: sys: fs: uefi: Implement File::flush)
Use f64 NaN in documentation instead of sqrt(-1.0) #150871 (Use f64 NaN in documentation instead of sqrt(-1.0))
Reenable GCC CI download #150873 (Reenable GCC CI download)
Emit an error for linking staticlibs on BPF #150878 (Emit an error for linking staticlibs on BPF)

This test currently doesn't fulfill its purpose, as `external dso_local` can still match `external {{.*}}`. Fix this by using CHECK-NOT directives. Also, this test is expanded to all platforms where it makes sense, instead of restricting to loongarch.

The current code applies `dso_local` to the internal generated symbols instead of the actually-externally one.

They were introduced back when std_detect was a standalone crate published to crates.io. The motivation for std_detect_dlsym_getauxval was to allow using getauxval without dlopen when statically linking musl, which we now unconditionally do for musl. And for std_detect_file_io to allow no_std usage, which std_detect now supports even with that feature enabled as it directly uses libc. This also prevents accidentally disabling runtime feature detection when using cargo build -Zbuild-std -Zbuild-std-features=

It is no longer a part of the stdarch repo and the rest is not necessary anymore due to no longer publishing to crates.io.

This will allow extra data to be attached to the `Pat` before it is returned.

std supports redirecting stdio file descriptors.

Rather than panicking.

- Make flush a noop since it is only for buffered writers. - Also forward fsync to datasync. UEFI does not have anything separate for metadata sync. Signed-off-by: Ayush Singh <[email protected]>

… a body. Handling for inherent associated consts is missing elsewhere, remove so it can be handled later in that handling. Diagnostic not always be emitted on associated constant Add a test case and Fix for a different ICE I encountered. I noticed when trying various permuations of the test case code to see if I could find anymore ICEs. I did, but not one that I expected. So in the instances of the a named const not having any args, insantiate it directly. Since it is likely an inherent assocaiated const. Added tests. Centralize the is_type_const() logic. I also noticed basically the exact same check in other part the code. Const blocks can't be a type_const, therefore this check is uneeded. Fix comment spelling error. get_all_attrs is not valid to call for all DefIds it seems. Make sure that if the type is omitted for a type_const that we don't ICE. Co-Authored-By: Boxy <[email protected]>

Tested using OVMF on QEMU. Signed-off-by: Ayush Singh <[email protected]>

@scottmcm

Reflection MVP I am opening this PR for discussion about the general design we should start out with, as there are various options (that are not too hard to transition between each other, so we should totally just pick one and go with it and reiterate later) r? @scottmcm and @joshtriplett project goal issue: rust-lang/rust-project-goals#406 tracking issue: rust-lang#146922 The design currently implemented by this PR is * `TypeId::info` (method, usually used as `id.info()` returns a `Type` struct * the `Type` struct has fields that contain information about the type * the most notable field is `kind`, which is a non-exhaustive enum over all possible type kinds and their specific information. So it has a `Tuple(Tuple)` variant, where the only field is a `Tuple` struct type that contains more information (The list of type ids that make up the tuple). * To get nested type information (like the type of fields) you need to call `TypeId::info` again. * There is only one language intrinsic to go from `TypeId` to `Type`, and it does all the work An alternative design could be * Lots of small methods (each backed by an intrinsic) on `TypeId` that return all the individual information pieces (size, align, number of fields, number of variants, ...) * This is how C++ does it (see https://lemire.me/blog/2025/06/22/c26-will-include-compile-time-reflection-why-should-you-care/ and https://isocpp.org/files/papers/P2996R13.html#member-queries) * Advantage: you only get the information you ask for, so it's probably cheaper if you get just one piece of information for lots of types (e.g. reimplementing size_of in terms of `TypeId::info` is likely expensive and wasteful) * Disadvantage: lots of method calling (and `Option` return types, or "general" methods like `num_fields` returning 0 for primitives) instead of matching and field accesses * a crates.io crate could implement `TypeId::info` in terms of this design The backing implementation is modular enough that switching from one to the other is probably not an issue, and the alternative design could be easier for the CTFE engine's implementation, just not as nice to use for end users (without crates wrapping the logic) One wart of this design that I'm fixing in separate branches is that `TypeId::info` will panic if used at runtime, while it should be uncallable

Use f64 NaN in documentation instead of sqrt(-1.0)

Reenable GCC CI download Now that we have the `gcc-dev` artifacts on CI. However, I forgot to bump download-ci-gcc-stamp before 🤦 So I will also have to bump it for this PR.

Emit an error for linking staticlibs on BPF Rather than panicking. Also a drive-by diagnostic type visibility reduction. Fixes rust-lang#149432

JonathanBrouwer · 2026-01-10T12:06:42Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-10T12:06:46Z

📌 Commit 5822afb has been approved by JonathanBrouwer

It is now in the queue for this repository.

matthiaskrgr · 2026-01-10T12:09:01Z

@bors r-
I already set up #150923
waiting for #150541 and will then push 150923 in the queue

rust-bors · 2026-01-10T12:09:05Z

Commit 5822afb has been unapproved.

matthiaskrgr · 2026-01-10T12:10:04Z

in general we are trying to have rollup, rollup=never, rollup, rollup=iffy so that the never,iffy block also gets smaller over time

JonathanBrouwer · 2026-01-10T12:11:21Z

Ah I see, makes sense, thanks!

asder8215 and others added 30 commits December 13, 2025 19:18

create_dir_all() operates iteratively instead of recursively

4081c14

check if current path is root through seeing if its parent is None

167ad11

Fix dso_local for external statics with linkage

5467a39

The current code applies `dso_local` to the internal generated symbols instead of the actually-externally one.

Unix implementation for stdio set/take/replace

1cd8752

Compile-Time Reflection MVP: tuples

a3359bd

Add size information

82028b0

Remove a couple of outdated fields in std_detect Cargo.toml

3fed6e6

It is no longer a part of the stdarch repo and the rest is not necessary anymore due to no longer publishing to crates.io.

Remove unnecessary module

c873d16

adding minicore to test file to avoid duplicating lang error

484ea76

Prepare for thir::Pat nodes having multiple user-type ascriptions

0495a73

Prefer to return Box<thir::Pat> instead of thir::PatKind

f85b898

This will allow extra data to be attached to the `Pat` before it is returned.

Initial plumbing for thir::PatExtra

bd77048

Replace AscribeUserType and ExpandedConstant with per-node data

8516c64

[miri] make closing stdio file descriptions noops

7e433eb

std supports redirecting stdio file descriptors.

Use f64 NaN in documentation instead of sqrt(-1.0)

fb296d7

Reenable GCC CI download

87d7167

Bump download-ci-gcc-stamp

58a9fdd

Emit an error for linking staticlibs on BPF

e0324b5

Rather than panicking.

Reduce visibility of some errors

90c84d0

Fix unpacking of gcc-dev component

6426635

std: sys: fs: uefi: Implement File::{flush, *sync}

f6f901f

- Make flush a noop since it is only for buffered writers. - Also forward fsync to datasync. UEFI does not have anything separate for metadata sync. Signed-off-by: Ayush Singh <[email protected]>

Introduce hir::ConstArgKind::Array

fc06a57

Lower hir::ConstArgKind::Array to a ValTree

618b0b5

Fix clippy

522be7f

Add mGCA array expression tests

f2f45ff

std: sys: fs: uefi: Implement File::write

ccc86f2

Tested using OVMF on QEMU. Signed-off-by: Ayush Singh <[email protected]>

JonathanBrouwer added 3 commits January 10, 2026 13:06

Rollup merge of rust-lang#150871 - simplify-partialord-doc, r=jhpratt

e7c3429

Use f64 NaN in documentation instead of sqrt(-1.0)

Rollup merge of rust-lang#150873 - reenable-gcc-download-ci, r=marcoieni

93f5a0f

Reenable GCC CI download Now that we have the `gcc-dev` artifacts on CI. However, I forgot to bump download-ci-gcc-stamp before 🤦 So I will also have to bump it for this PR.

Rollup merge of rust-lang#150878 - bpf_staticlib_error, r=Urgau

5822afb

Emit an error for linking staticlibs on BPF Rather than panicking. Also a drive-by diagnostic type visibility reduction. Fixes rust-lang#149432

rust-bors bot added the rollup A PR which is a rollup label Jan 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2026

JonathanBrouwer closed this Jan 10, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 14 pull requests #150924

Rollup of 14 pull requests #150924

Uh oh!

JonathanBrouwer commented Jan 10, 2026 •

edited by rustbot

Loading

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

matthiaskrgr commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

matthiaskrgr commented Jan 10, 2026

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Rollup of 14 pull requests #150924

Rollup of 14 pull requests #150924

Uh oh!

Conversation

JonathanBrouwer commented Jan 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

matthiaskrgr commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

matthiaskrgr commented Jan 10, 2026

Uh oh!

JonathanBrouwer commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

JonathanBrouwer commented Jan 10, 2026 •

edited by rustbot

Loading