Rollup of 8 pull requests #151395

Zalathar · 2026-01-20T07:00:12Z

Successful merges:

coverage: Sort the expansion tree to help choose a single BCB for child expansions #149587 (coverage: Sort the expansion tree to help choose a single BCB for child expansions)
Add dist step for Enzyme #150071 (Add dist step for Enzyme)
Add scalar support for offload #150288 (Add scalar support for offload)
Add new "hide deprecated items" setting in rustdoc #151091 (Add new "hide deprecated items" setting in rustdoc)
rustdoc: Fix ICE when deprecated note is not resolved on the correct DefId #151255 (rustdoc: Fix ICE when deprecated note is not resolved on the correct DefId)
Fix terminal width dependent tests #151375 (Fix terminal width dependent tests)
add basic TokenStream api tests #151384 (add basic TokenStream api tests)
rustc-dev-guide subtree update #151391 (rustc-dev-guide subtree update)

r? @ghost

Create a similar rollup

Remove references to homu and fix bors delegation command

candidate preference, mention RPITIT issue

Add rust-analyzer setup for out-of-tree rustc_private crates

…`DefId`

…he correct `DefId`

Added section on using GitHub Dev for PR inspection

Match "build-rust-analyzer" in src/building/how-to-build-and-run.md and in the default editor settings from the rustc repo.

Fix typo.

The link for finding issues leads to a 404. This adds the repo to the query in the url so the search works.

Fix issue query deadlink in getting-started.md

add range-diff triagebot option

…ng is working as expected

… setting, allowing to simplify JS code

… value in the end, no need to keep it around. Also: takes into account "is_in_effect"

Zalathar · 2026-01-20T07:00:25Z

Rollup of everything.

@bors r+ rollup=never p=5

rust-bors · 2026-01-20T07:00:28Z

📌 Commit 7c33b49 has been approved by Zalathar

It is now in the queue for this repository.

rust-bors · 2026-01-20T12:51:07Z

☀️ Test successful - CI
Approved by: Zalathar
Duration: 3h 49m 37s
Pushing fffc4fc to main...

rust-timer · 2026-01-20T12:53:25Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149587	coverage: Sort the expansion tree to help choose a single B…	`ff2e9cec42aba9328f35a8906b974fe8cc4c6266` (link)
#150071	Add dist step for Enzyme	`db3e4585d212d0c5f247320c07a50fe9888e1db6` (link)
#150288	Add scalar support for offload	`d73c772b497ff382602066bdecc6f3217e379d56` (link)
#151091	Add new "hide deprecated items" setting in rustdoc	`133ecb024ca33b9fb8cf9f87c874736f657cf98a` (link)
#151255	rustdoc: Fix ICE when deprecated note is not resolved on th…	`31a3c60f83933da6e1108503ad552002d66959dc` (link)
#151375	Fix terminal width dependent tests	`e24ecd739cd5c9f117cf469e0aceeff43329dfff` (link)
#151384	add basic `TokenStream` api tests	`22cd6bd16781be26fcc667867873c18e68162d2d` (link)
#151391	rustc-dev-guide subtree update	`5a3203ba7af5a4b75790e41850d681892e78f0a8` (link)

previous master: 7981818138

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-20T12:54:24Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7981818 (parent) -> fffc4fc (this PR)

Test differences

Show 22 test diffs

Stage 1

[coverage-map] tests/coverage/macros/pass-through.rs: [missing] -> pass (J3)
[coverage-run] tests/coverage/macros/pass-through.rs: [missing] -> ignore (ignored when the profiler runtime is not available) (J3)
[ui] tests/rustdoc-ui/intra-doc/deprecated-note-from-reexported.rs: [missing] -> pass (J3)
[codegen] tests/codegen-llvm/gpu_offload/scalar_device.rs#amdgpu: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[codegen] tests/codegen-llvm/gpu_offload/scalar_device.rs#nvptx: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)
[codegen] tests/codegen-llvm/gpu_offload/scalar_host.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J4)

Stage 2

[codegen] tests/codegen-llvm/gpu_offload/scalar_device.rs#amdgpu: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J0)
[codegen] tests/codegen-llvm/gpu_offload/scalar_device.rs#nvptx: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J0)
[codegen] tests/codegen-llvm/gpu_offload/scalar_host.rs: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J0)
[coverage-map] tests/coverage/macros/pass-through.rs: [missing] -> pass (J0)
[ui] tests/rustdoc-ui/intra-doc/deprecated-note-from-reexported.rs: [missing] -> pass (J1)
[coverage-run] tests/coverage/macros/pass-through.rs: [missing] -> ignore (ignored when the profiler runtime is not available) (J2)
[coverage-run] tests/coverage/macros/pass-through.rs: [missing] -> ignore (ignored when cross-compiling) (J5)
[coverage-run] tests/coverage/macros/pass-through.rs: [missing] -> pass (J6)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard fffc4fcf96b30bc838551de5104d74f82400b35b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 10965.0s -> 13360.7s (+21.8%)
dist-x86_64-apple: 7778.9s -> 9457.9s (+21.6%)
dist-aarch64-msvc: 5990.1s -> 6964.3s (+16.3%)
dist-aarch64-apple: 7874.7s -> 8782.8s (+11.5%)
dist-arm-linux-gnueabi: 4776.5s -> 5258.1s (+10.1%)
x86_64-mingw-1: 9642.2s -> 10613.7s (+10.1%)
tidy: 197.3s -> 178.8s (-9.4%)
dist-various-1: 3854.4s -> 4214.5s (+9.3%)
x86_64-gnu-llvm-21-1: 4464.8s -> 4091.5s (-8.4%)
x86_64-msvc-ext1: 7526.5s -> 8098.2s (+7.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-20T13:32:26Z

Finished benchmarking commit (fffc4fc): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.9%]	18
Regressions ❌ (secondary)	0.7%	[0.2%, 1.1%]	24
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.9%]	18

Max RSS (memory usage)

Results (primary -0.7%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Cycles

Results (primary -3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.4%, -3.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.4%	[-3.4%, -3.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.092s -> 475.617s (0.53%)
Artifact size: 383.30 MiB -> 383.32 MiB (0.00%)

Zalathar · 2026-01-20T13:35:19Z

Those are doc regressions, so let's try the obvious subject:

@rust-timer build 31a3c60

rustdoc: Fix ICE when deprecated note is not resolved on the correct DefId #151255

rust-timer · 2026-01-20T13:36:27Z

Finished benchmarking commit (31a3c60): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: missing data

Kobzol · 2026-01-20T13:39:07Z

(purged 31a3c60f83933da6e1108503ad552002d66959dc from the rustc-perf DB)

tshepang and others added 30 commits January 12, 2026 22:33

add range-diff triagebot option

97a06fe

Remove references to homu and fix bors delegation command

513b6ad

Merge pull request rust-lang#2727 from Kobzol/remove-homu-references

ce80d14

Remove references to homu and fix bors delegation command

Minor doc and ty fixes

bc751ad

Allow bounded types

2c9c5d1

Add new "hide deprecated items" setting in rustdoc

4ded639

Refactor Enzyme step

316627e

Add dist step for Enzyme

85e01e3

Add rust-analyzer setup for out-of-tree rustc_private crates

f19591a

add RPITIT cycle issue

21f269e

move section

908ae5a

Merge pull request rust-lang#2730 from lcnr/main

bbad40d

candidate preference, mention RPITIT issue

Rename "remarks on perma unstable features" to "external rustc_drivers"

9e4c55a

Merge pull request rust-lang#2729 from reddevilmidzy/oot

5bed84a

Add rust-analyzer setup for out-of-tree rustc_private crates

Added section on using GitHub Dev for PR inspection

308b736

rustdoc: Fix ICE when deprecated note is not resolved on the correct …

b3a5f53

…`DefId`

Add regression test for ICE when deprecated note is not resolved on t…

1faaa76

…he correct `DefId`

Merge pull request rust-lang#2728 from reddevilmidzy/tip

2f393eb

Added section on using GitHub Dev for PR inspection

Fix typo.

eed703c

Match "build-rust-analyzer" in src/building/how-to-build-and-run.md and in the default editor settings from the rustc repo.

Merge pull request rust-lang#2731 from Ozzy1423/main

0dc7b37

Fix typo.

Fix issue query deadlink in getting-started.md

b0958e5

The link for finding issues leads to a 404. This adds the repo to the query in the url so the search works.

Merge pull request rust-lang#2732 from tejom/patch-1

0b2584f

Fix issue query deadlink in getting-started.md

Fix terminal dependent tests

8a57358

Merge pull request rust-lang#2726 from rust-lang/tshepang/range-diff

3e62e12

add range-diff triagebot option

Add rustdoc GUI test to ensure that the "hide deprecated items" setti…

9f965bc

…ng is working as expected

Improve JS source code for settings

5561167

Rename sans-serif CSS class into sans-serif-fonts to match the JS…

bf49068

… setting, allowing to simplify JS code

Add scalar support for both host and device

307a4fc

add basic TokenStream api tests

60e488e

Simplify IndexItem::deprecation field: since we only need a boolean…

9e5e432

… value in the end, no need to keep it around. Also: takes into account "is_in_effect"

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jan 20, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 20, 2026

rust-bors bot merged commit fffc4fc into rust-lang:main Jan 20, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 20, 2026

Zalathar deleted the rollup-8gANGZS branch January 20, 2026 13:09

This was referenced Jan 20, 2026

Revert ice-deprecated-note-on-reexport due to rustdoc ICE in diesel benchmark (PR 151120) #151237

Closed

some more rustc_borrowck cleanups #151374

Open

rustbot added the perf-regression Performance regression. label Jan 20, 2026

This comment has been minimized.

Sign in to view

Zalathar mentioned this pull request Jan 20, 2026

rustdoc: Fix ICE when deprecated note is not resolved on the correct DefId #151255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 8 pull requests #151395

Rollup of 8 pull requests #151395

Zalathar commented Jan 20, 2026

Uh oh!

Zalathar commented Jan 20, 2026

Uh oh!

rust-bors bot commented Jan 20, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 20, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 20, 2026

Uh oh!

Zalathar commented Jan 20, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jan 20, 2026

Uh oh!

Kobzol commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Rollup of 8 pull requests #151395

Rollup of 8 pull requests #151395

Conversation

Zalathar commented Jan 20, 2026

Uh oh!

Zalathar commented Jan 20, 2026

Uh oh!

rust-bors bot commented Jan 20, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 20, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 20, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 20, 2026

Overall result: ❌ regressions - please read the text below

Uh oh!

Zalathar commented Jan 20, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jan 20, 2026

Overall result: no relevant changes - no action needed

Uh oh!

Kobzol commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants