On obligation errors point at the unfulfilled binding when possible #64151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
CC @nikomatsakis @Centril, I'd like a couple of extra eyes to make sure I'm not pointing at the wrong binding accidentally. |
estebank
commented
Sep 4, 2019
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
binding-error
branch
2 times, most recently
from
6e5a280 to
07ea946
Compare
Centril
reviewed
Sep 5, 2019
estebank
force-pushed
the
binding-error
branch
from
d30abc5 to
3109b1f
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
|
📌 Commit 3109b1f47891a11037e446a5809bf385f5326b12 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
|
Sorry on mobile until Friday. I don't know where it was |
|
I believe this might be the same as #46948 |
estebank
force-pushed
the
binding-error
branch
from
3109b1f to
eac2b02
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
bors
added
the
S-waiting-on-review
estebank
force-pushed
the
binding-error
branch
from
58ffcbd to
ff75124
Compare
|
Progress: fixed the NLL tests. @bors r=varkor |
|
📌 Commit ff75124 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 7, 2019
consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 8, 2019
consistent handling of missing sysroot spans Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue. I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #42855, #64130, #64135. Fix #61860.