-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the 'dereferenceable' attribute from Box #66645
Conversation
@bors try |
⌛ Trying commit be07911 with merge d7c557381942c3cac82b5e4585f195ec369c2f68... |
@rust-timer queue |
Awaiting bors try build completion |
☀️ Try build successful - checks-azure |
Queued d7c557381942c3cac82b5e4585f195ec369c2f68 with parent 083b5a0, future comparison URL. |
Finished benchmarking try commit d7c557381942c3cac82b5e4585f195ec369c2f68, comparison URL. |
@Mark-Simulacrum this said "finished benchmarking" but there are no results at the comparison URL yet? |
@RalfJung It does now. It takes some time before the parent commit gets benchmarked after |
I see. Timings look like noise. But this is not necessarily a good benchmark. |
r=me if there are no concerns left (e.g. perf) |
@pnkfelix so how do we proceed? I guess we should nominate this for T-lang and T-compiler discussion? |
@bors r+ rollup=never |
📌 Commit d0b9833 has been approved by |
(I marked as rollup=never because its not totally certain that there won't be performance regressions associated with this, and I'd rather pay the cost of an extra bors cycle up front than have to track that down in a rollup or have it otherwise masked by unrelated improvements in a rollup.) |
☀️ Test successful - checks-azure |
Fixes #66600
r? @eddyb @rkruppe