Stabilize `Seek::stream_position` (feature `seek_convenience`) #70904

LukasKalbertodt · 2020-04-07T21:42:07Z

Tracking issue: #59359

Unresolved questions from tracking issue:

"Override stream_len for File?" → we can do that in the future, this does not block stabilization.
"Rename to len and position?" → as noted in the tracking issue, both of these shorter names have problems (len is usually a cheap getter, position clashes with Cursor). I do think the current names are perfectly fine.
"Rename stream_position to tell?" → as mentioned in the comment bringing this up, stream_position is more descriptive. I don't think tell would be a good name.

What remains to decide, is whether or not adding these methods is worth it.

LukasKalbertodt · 2020-04-09T13:51:02Z

FYI: a new discussion potentially arguing against stabilization just emerged in the tracking issue.

SimonSapin · 2020-04-09T16:30:52Z

Highfive is configured in https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json#L6, and this list (in particular my absence from it ;)) is deliberate.

r? @kennytm

In general though the right time for a stabilization is after FCP has happened, because of cases like this:

a new discussion potentially arguing against stabilization just emerged

LukasKalbertodt · 2020-04-09T16:43:22Z

Highfive is configured in https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json#L6, and this list (in particular my absence from it ;)) is deliberate.

Oh, oops. I simply checked https://www.rust-lang.org/governance/teams/library to see if kennytm is in the libs team, didn't see them listed there and assumed this was a highfive bug. Sorry!

In general though the right time for a stabilization is after FCP has happened, because of cases like this:

I assumed that FCPs mostly happen on the PR and not the tracking issue. At least I think that that's mostly what I saw so far. I even considered asking for FCP on the tracking issues instead of creating a PR but decided against it because I thought FCP on PR is the "proper" way to do it. If you want, I can close this PR until FCP is complete.

Dylan-DPC-zz · 2020-05-15T15:47:12Z

r? @dtolnay

dtolnay · 2020-05-28T02:41:17Z

@rust-lang/libs:
I don't have a strong opinion either way on this one, but I am open to accepting these methods. I would be interested what you all think. Some of us weighed in previously in #58422 (comment) when these were originally implemented.

@rfcbot fcp merge

rfcbot · 2020-05-28T02:41:18Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

Concerns:

non-atomic-tell (Stabilize Seek::stream_position (feature seek_convenience) #70904 (comment))

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

sfackler · 2020-05-28T11:23:20Z

@rfcbot concern non-atomic-tell

stream_position seems totally reasonable to me (maybe modulo a rename), but I'm not really a huge fan of stream_position being implemented by 3 seeks. It's unfortunately non-atomic and (almost?) every seekable construct of finite length should have a more "proper" method to return its length.

rfcbot · 2021-01-17T01:51:24Z

🔔 This is now entering its final comment period, as per the review above. 🔔

pthariensflame · 2021-01-23T19:24:55Z

since attribute needs updating.

rfcbot · 2021-01-27T02:00:47Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

m-ou-se · 2021-01-27T07:38:17Z

@bors r+ rollup

bors · 2021-01-27T07:38:18Z

📌 Commit 8a18fb0 has been approved by m-ou-se

Rollup of 13 pull requests Successful merges: - rust-lang#70904 (Stabilize `Seek::stream_position` (feature `seek_convenience`)) - rust-lang#79951 (Refractor a few more types to `rustc_type_ir` ) - rust-lang#80868 (Print failure message on all tests that should panic, but don't) - rust-lang#81062 (Improve diagnostics for Precise Capture) - rust-lang#81277 (Make more traits of the From/Into family diagnostic items) - rust-lang#81284 (Make `-Z time-passes` less noisy) - rust-lang#81379 (Improve URLs handling) - rust-lang#81416 (Tweak suggestion for missing field in patterns) - rust-lang#81426 (const_evaluatable: expand abstract consts in try_unify) - rust-lang#81428 (compiletest: Add two more unit tests) - rust-lang#81430 (add const_evaluatable_checked test) - rust-lang#81433 (const_evaluatable: stop looking into type aliases) - rust-lang#81445 (Update cargo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Most of the `seek_convenience` feature was stablized, but `stream_len` was not [0]. To minimize version incompatibilities here, just remove our `stream_len` functions for now and rely on the defaults. [0]: rust-lang/rust#70904

rust-highfive assigned kennytm Apr 7, 2020

This comment has been minimized.

Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2020

This comment has been minimized.

Sign in to view

rust-highfive assigned SimonSapin and unassigned kennytm Apr 7, 2020

jonas-schievink added this to the 1.44 milestone Apr 7, 2020

LukasKalbertodt mentioned this pull request Apr 7, 2020

Tracking issue for Seek::{stream_len, stream_position} (feature seek_convenience) #59359

Open

2 tasks

rust-highfive assigned kennytm and unassigned SimonSapin Apr 9, 2020

Dylan-DPC-zz modified the milestones: 1.44, 1.45 Apr 21, 2020

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 15, 2020

rust-highfive assigned dtolnay and unassigned kennytm May 15, 2020

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels May 28, 2020

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jan 17, 2021

Stabilize Seek::stream_position & change feature of Seek::stream_len

8a18fb0

LukasKalbertodt force-pushed the stabilize-seek-convenience branch from 55689e2 to 8a18fb0 Compare January 24, 2021 09:14

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jan 27, 2021

rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jan 27, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2021

This was referenced Jan 27, 2021

Rollup of 15 pull requests #81435

Closed

Rollup of 15 pull requests #81437

Closed

This was referenced Jan 27, 2021

Rollup of 19 pull requests #81449

Closed

Rollup of 18 pull requests #81450

Closed

JohnTitor mentioned this pull request Jan 28, 2021

Rollup of 13 pull requests #81461

Merged

bors merged commit 025a850 into rust-lang:master Jan 28, 2021

rustbot modified the milestones: 1.48.0, 1.51.0 Jan 28, 2021

LukasKalbertodt deleted the stabilize-seek-convenience branch January 28, 2021 12:13

apiraino removed the to-announce Announce this issue on triage meeting label Jan 28, 2021

This was referenced Feb 20, 2023

Calculate duration for mp3s RustAudio/rodio#481

Closed

Make stream_len more atomic #108352

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stabilize `Seek::stream_position` (feature `seek_convenience`) #70904

Stabilize `Seek::stream_position` (feature `seek_convenience`) #70904

Uh oh!

LukasKalbertodt commented Apr 7, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

LukasKalbertodt commented Apr 9, 2020

Uh oh!

SimonSapin commented Apr 9, 2020

Uh oh!

LukasKalbertodt commented Apr 9, 2020

Uh oh!

Dylan-DPC-zz commented May 15, 2020

Uh oh!

dtolnay commented May 28, 2020

Uh oh!

rfcbot commented May 28, 2020 •

edited by Amanieu

Loading

Uh oh!

sfackler commented May 28, 2020

Uh oh!

rfcbot commented Jan 17, 2021

Uh oh!

pthariensflame commented Jan 23, 2021

Uh oh!

rfcbot commented Jan 27, 2021

Uh oh!

m-ou-se commented Jan 27, 2021

Uh oh!

bors commented Jan 27, 2021

Uh oh!

Uh oh!

Stabilize Seek::stream_position (feature seek_convenience) #70904

Stabilize Seek::stream_position (feature seek_convenience) #70904

Uh oh!

Conversation

LukasKalbertodt commented Apr 7, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

LukasKalbertodt commented Apr 9, 2020

Uh oh!

SimonSapin commented Apr 9, 2020

Uh oh!

LukasKalbertodt commented Apr 9, 2020

Uh oh!

Dylan-DPC-zz commented May 15, 2020

Uh oh!

dtolnay commented May 28, 2020

Uh oh!

rfcbot commented May 28, 2020 • edited by Amanieu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sfackler commented May 28, 2020

Uh oh!

rfcbot commented Jan 17, 2021

Uh oh!

pthariensflame commented Jan 23, 2021

Uh oh!

rfcbot commented Jan 27, 2021

Uh oh!

m-ou-se commented Jan 27, 2021

Uh oh!

bors commented Jan 27, 2021

Uh oh!

Uh oh!

Stabilize `Seek::stream_position` (feature `seek_convenience`) #70904

Stabilize `Seek::stream_position` (feature `seek_convenience`) #70904

rfcbot commented May 28, 2020 •

edited by Amanieu

Loading