Skip to content

Rename TypeckTables to TypeckResults. #72983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2020
Merged

Rename TypeckTables to TypeckResults. #72983

merged 1 commit into from
Jul 17, 2020

Conversation

Lezzz
Copy link
Contributor

@Lezzz Lezzz commented Jun 4, 2020

Originally suggested by @eddyb.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@nikomatsakis
Copy link
Contributor

This needs a rebase and seems to have failed in CI but I'm in favor =)

@nikomatsakis nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2020
@JohnCSimon

This comment has been minimized.

Sign in to view
@JohnCSimon

This comment has been minimized.

Sign in to view
@Lezzz Lezzz force-pushed the rename-typeck branch 2 times, most recently from ec9b5d9 to e3cbb62 Compare June 30, 2020 19:54
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 1, 2020

📌 Commit e3cbb62 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2020
@nikomatsakis
Copy link
Contributor

I'm nominated for @rust-lang/compiler even though I just r+'d this just to draw attention to it. This PR changes from TypeckTables to TypeckResults. I think the name is objectively better here but I thought people should be aware of the change.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 1, 2020
@Manishearth
Rollup merge of rust-lang#72983 - Lezzz:rename-typeck, r=nikomatsakis
6b34642 
Rename TypeckTables to TypeckResults.

Originally suggested by @eddyb.
@Manishearth Manishearth mentioned this pull request Jul 1, 2020
Closed
@spastorino spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 1, 2020
@spastorino
Copy link
Member

Adding T-compiler label so the nomination can be picked up by our automations for tomorrow's weekly meeting :).

@nikomatsakis
Copy link
Contributor

Oh and cc @rust-lang/wg-rustc-dev-guide I bet there are rustc-dev-guide entries to be updated here, now that we mention it...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2020
@Manishearth
Rollup merge of rust-lang#72983 - Lezzz:rename-typeck, r=nikomatsakis
c6d35e7 
Rename TypeckTables to TypeckResults.

Originally suggested by @eddyb.
@Manishearth Manishearth mentioned this pull request Jul 2, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2020
@Manishearth
Rollup merge of rust-lang#72983 - Lezzz:rename-typeck, r=nikomatsakis
b2d64ee 
Rename TypeckTables to TypeckResults.

Originally suggested by @eddyb.
@Manishearth Manishearth mentioned this pull request Jul 2, 2020
Closed
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 16, 2020
@bors
Copy link
Collaborator

bors commented Jul 17, 2020

⌛ Testing commit dced0b8900a653a59643bb06fdf812c5f8c7a9a9 with merge ab592bb4985cc915f0dfcde2a8048825224ce90d...

@bors
Copy link
Collaborator

bors commented Jul 17, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2020
@Manishearth

This comment has been minimized.

Sign in to view
@eddyb
Copy link
Member

eddyb commented Jul 17, 2020

That was #74140, needs rebase now.

@eddyb
Copy link
Member

eddyb commented Jul 17, 2020

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Jul 17, 2020

📌 Commit 1e6adad has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@bors
Copy link
Collaborator

bors commented Jul 17, 2020

⌛ Testing commit 1e6adad with merge 7dcbea9e21e1ce0ade7263ac715631b5a51ed775...

@bors
Copy link
Collaborator

bors commented Jul 17, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 17, 2020
@eddyb
Copy link
Member

eddyb commented Jul 17, 2020

Looks like a network error?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@bors
Copy link
Collaborator

bors commented Jul 17, 2020

⌛ Testing commit 1e6adad with merge 39d5a61...

@bors bors mentioned this pull request Jul 17, 2020
Merged
@bors
Copy link
Collaborator

bors commented Jul 17, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: nikomatsakis
Pushing 39d5a61 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2020
@bors bors merged commit 39d5a61 into rust-lang:master Jul 17, 2020
This was referenced Jul 17, 2020
Merged
Merged
@Lezzz Lezzz deleted the rename-typeck branch July 21, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Lezzz @rust-highfive @bors @nikomatsakis @JohnCSimon @spastorino @Manishearth @mark-i-m @eddyb @LeSeulArtichaut