Skip to content

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Jul 3, 2021

A few months has passed since #84207. I think now it's time for the final removal.

Closes #27751.

r? @m-ou-se

@crlf0710 crlf0710 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 3, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2021
@rust-log-analyzer

This comment has been minimized.

@crlf0710 crlf0710 force-pushed the remove-std-raw-mod branch from 2320ad9 to efaf4d3 Compare July 3, 2021 04:47
@rust-log-analyzer

This comment has been minimized.

@crlf0710 crlf0710 force-pushed the remove-std-raw-mod branch from efaf4d3 to 4bc353b Compare July 3, 2021 05:10
@rust-log-analyzer

This comment has been minimized.

@SimonSapin
Copy link
Contributor

Looks good, thanks!

This removal was proposed and accepted in the pointer metadata RFC rust-lang/rfcs#2580

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 3, 2021

📌 Commit 0d1919c has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2021
@jyn514
Copy link
Member

jyn514 commented Jul 3, 2021

Wait, what? This is stable, you can't just remove it.

@bors r- cc @rust-lang/libs-api

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2021
@jyn514
Copy link
Member

jyn514 commented Jul 3, 2021

Oh I'm sorry, it was unstable but annotated in the module so I didn't see it. Sorry for the ping.

@bors r=SimonSapin

@bors
Copy link
Collaborator

bors commented Jul 3, 2021

📌 Commit 0d1919c has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2021
@dtolnay
Copy link
Member

dtolnay commented Jul 3, 2021

Yeah this was never stable.

warning: use of deprecated module `std::raw`: use pointer metadata APIs instead https://github.com/rust-lang/rust/issues/81513
 --> src/lib.rs:1:5
  |
1 | use core::raw;
  |     ^^^^^^^^^
  |
  = note: `#[warn(deprecated)]` on by default

error[E0658]: use of unstable library feature 'raw'
 --> src/lib.rs:1:5
  |
1 | use core::raw;
  |     ^^^^^^^^^
  |
  = note: see issue #27751 <https://github.com/rust-lang/rust/issues/27751> for more information

warning: use of deprecated module `std::raw`: use pointer metadata APIs instead https://github.com/rust-lang/rust/issues/81513
 --> src/lib.rs:2:5
  |
2 | use std::raw;
  |     ^^^^^^^^

error[E0658]: use of unstable library feature 'raw'
 --> src/lib.rs:2:5
  |
2 | use std::raw;
  |     ^^^^^^^^
  |
  = note: see issue #27751 <https://github.com/rust-lang/rust/issues/27751> for more information

@bors
Copy link
Collaborator

bors commented Jul 4, 2021

⌛ Testing commit 0d1919c with merge 71a567f...

@bors
Copy link
Collaborator

bors commented Jul 4, 2021

☀️ Test successful - checks-actions
Approved by: SimonSapin
Pushing 71a567f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2021
@bors bors merged commit 71a567f into rust-lang:master Jul 4, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 4, 2021
@crlf0710 crlf0710 deleted the remove-std-raw-mod branch July 4, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for raw stabilization (raw::TraitObject)
9 participants