Skip to content

Revert "Fix intra doc link ICE when trying to get traits in scope for primitive" #95682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Apr 5, 2022

Reverts #95645

This is only to confirm that the perf drop comes from this PR.

r? @GuillaumeGomez

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 5, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2022
@GuillaumeGomez
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2022
@bors
Copy link
Collaborator

bors commented Apr 5, 2022

⌛ Trying commit 572f335 with merge fed203b29ae7e76c9b96595df5873057c19cac46...

@bors
Copy link
Collaborator

bors commented Apr 5, 2022

☀️ Try build successful - checks-actions
Build commit: fed203b29ae7e76c9b96595df5873057c19cac46 (fed203b29ae7e76c9b96595df5873057c19cac46)

@rust-timer
Copy link
Collaborator

Queued fed203b29ae7e76c9b96595df5873057c19cac46 with parent 634770c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fed203b29ae7e76c9b96595df5873057c19cac46): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 1 2 9 2
mean2 N/A 0.3% -20.6% -18.2% -20.6%
max N/A 0.3% -24.4% -24.2% -24.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2022
@GuillaumeGomez GuillaumeGomez deleted the revert-95645-intra-doc-link-ice-traits-in-scope-primitive branch April 5, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants