Enforce static lifetimes in consts during late resolution #95776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred in src/tools/rustfmt. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
655cbd5 to
0b92aca
Compare
cjgillot
added
S-blocked
This comment was marked as resolved.
This comment was marked as resolved.
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
ee22022 to
bdc97fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
bdc97fa to
40799a5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
40799a5 to
f06716f
Compare
cjgillot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
f06716f to
8660a14
Compare
|
r=me after addressing #95776 (comment) and squashing commits. |
The extra diagnostics come from the compiler no longer aborting before typeck.
cjgillot
force-pushed
the
ast-lifetimes-static
branch
from
8660a14 to
7d990a8
Compare
|
@bors r+ |
|
📌 Commit 7d990a8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (76d4862): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 5, 2022
…ark-Simulacrum Enable full revision in const generics ui tests The ICEs no longer occur since rust-lang#95776 so the revisions can be reenabled Also adds some regression tests for issues that no longer ICE because of it closes rust-lang#77357 closes rust-lang#78180 closes rust-lang#83993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the handling of implicitly and explicitly static lifetimes in constants from HIR to the AST.