Update error codes to match the current implementation #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
the
S-waiting-on-review
This was referenced Aug 31, 2020
jyn514
force-pushed
the
diagnostic-codes
branch
from
c535d39 to
0e82872
Compare
|
There's an example PR adding an error code in rust-lang/rust#76143, I'll mention that in the change. |
- All codes are in one crate, `rustc_error_codes` - Extended descriptions are loaded using `include_str!` - Give an example of a PR adding an error code
jyn514
force-pushed
the
diagnostic-codes
branch
from
0e82872 to
e9468e1
Compare
|
r? @estebank The wg decided it would be good to get more feedback from compiler team, not just merging things on our own (https://rust-lang.zulipchat.com/#narrow/stream/196385-t-compiler.2Fwg-rustc-dev-guide/topic/meeting.202020-08-25/near/208740355). Estebank, are you interested in reviewing this? |
|
Maybe @GuillaumeGomez would also be interested in reviewing? |
GuillaumeGomez
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc_error_codesinclude_str!I wrote this just by looking at the code, not by talking with anyone about it, so this might not be perfectly accurate.
Follow-up to #838 (comment).
r? @mark-i-m