Always show errors when present #1276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when there were no relevant changes to show, we didn't show benchmark errors. However, it always makes sense to show new benchmark errors. This change makes it so that new benchmark errors are always shown when present.
Kobzol
reviewed
Apr 5, 2022
Kobzol
approved these changes
Apr 5, 2022
|
The CI failure is due to the fact that hyper no longer builds. This has already been reported here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when there were no relevant changes to show, we didn't show new benchmark errors. For example, in this PR, the perf result showed as not being relevant and thus hid the fact that one of the benchmarks was not building. It always makes sense to show new benchmark errors even if the perf results are otherwise not relevant. This change makes it so.