Skip to content

Feat; filter collectors jobs by status #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Feat; filter collectors jobs by status #2236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
904af9a
Feat; filter collectors jobs by status
Jamesbarford Sep 2, 2025
237858f
PR Feedback; use a JS object over a set, remove `:key` on table row
Jamesbarford Sep 2, 2025
64485f7
PR Feedback; keep `Failed` jobs in the Collectors job list
Jamesbarford Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
131 changes: 100 additions & 31 deletions site/frontend/src/pages/status_new/collector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script setup lang="ts">
import {CollectorConfig} from "./data";
import {ref, Ref} from "vue";
import {CollectorConfig, BenchmarkJobStatus} from "./data";

const props = defineProps<{
collector: CollectorConfig;
Expand All @@ -8,6 +9,23 @@ const props = defineProps<{
function statusClass(c: CollectorConfig): string {
return c.isActive ? "active" : "inactive";
}

const FILTERS: BenchmarkJobStatus[] = [
"InProgress",
"Queued",
"Success",
"Failed",
];
const ACTIVE_FILTERS: Ref<Record<BenchmarkJobStatus, boolean>> = ref({
InProgress: true,
Queued: true,
Success: false,
Failed: true,
});

function filterJobByStatus(status: string) {
ACTIVE_FILTERS.value[status] = !ACTIVE_FILTERS.value[status];
}
</script>

<template>
Expand Down Expand Up @@ -56,6 +74,26 @@ function statusClass(c: CollectorConfig): string {
</div>

<div class="table-collector-wrapper">
<div class="table-collector-status-filter-wrapper">
<div class="table-collector-status-filters">
<strong>Filter by job status:</strong>
<div class="table-collector-status-filter-btn-wrapper">
<template v-for="filter in FILTERS">
<button
class="table-collector-status-filter-btn"
@click="filterJobByStatus(filter)"
>
{{ filter }}
<input
type="checkbox"
value="filter"
:checked="ACTIVE_FILTERS[filter]"
/>
</button>
</template>
</div>
</div>
</div>
<table class="table-collector" style="border-collapse: collapse">
<caption>
current benchmark jobs
Expand All @@ -71,22 +109,24 @@ function statusClass(c: CollectorConfig): string {
</tr>
</thead>
<tbody>
<tr v-for="job in collector.jobs">
<td class="table-cell-padding">
{{ job.requestTag }}
</td>
<td class="table-cell-padding">
{{ job.status }}
</td>
<td class="table-cell-padding">
{{ job.startedAt }}
</td>
<td class="table-cell-padding">{{ job.backend }}</td>
<td class="table-cell-padding">{{ job.profile }}</td>
<td class="table-cell-padding">
{{ job.dequeCounter }}
</td>
</tr>
<template v-for="job in collector.jobs">
<tr v-if="ACTIVE_FILTERS[job.status]">
<td class="table-cell-padding">
{{ job.requestTag }}
</td>
<td class="table-cell-padding">
{{ job.status }}
</td>
<td class="table-cell-padding">
{{ job.startedAt }}
</td>
<td class="table-cell-padding">{{ job.backend }}</td>
<td class="table-cell-padding">{{ job.profile }}</td>
<td class="table-cell-padding">
{{ job.dequeCounter }}
</td>
</tr>
</template>
</tbody>
</table>
</div>
Expand All @@ -98,8 +138,11 @@ function statusClass(c: CollectorConfig): string {
</template>

<style lang="scss" scoped>
$sm-padding: 8px;
$sm-radius: 8px;

.collector-card {
border-radius: 8px;
border-radius: $sm-radius;
flex-direction: column;
justify-content: space-between;
padding: 16px;
Expand All @@ -109,11 +152,11 @@ function statusClass(c: CollectorConfig): string {
}
.collector-name {
font-size: 1.5em;
padding: 8px;
padding: $sm-padding;
}

.meta {
padding: 8px;
padding: $sm-padding;
}

.collector-meta {
Expand All @@ -134,13 +177,39 @@ function statusClass(c: CollectorConfig): string {
}

.collector-sm-padding-left-right {
padding: 0px 8px;
padding: 0px $sm-padding;
}
.collector-sm-padding-left {
padding-left: 8px;
padding-left: $sm-padding;
}
.collector-sm-padding-right {
padding-right: 8px;
padding-right: $sm-padding;
}

.table-collector-status-filter-wrapper {
padding: $sm-padding 0px;
}

.table-collector-status-filters {
display: flex;
flex-direction: column;
}

.table-collector-status-filter-btn-wrapper {
padding-top: $sm-padding;
display: flex;
flex-direction: row;
}

.table-collector-status-filter-btn {
border: 1px solid #333;
border-radius: $sm-radius;
width: 100%;
margin-right: $sm-padding;
}

.table-collector-status-filter-btn:hover {
transition: 250ms;
}

.status {
Expand All @@ -158,10 +227,10 @@ function statusClass(c: CollectorConfig): string {
}

.table-collector-wrapper {
padding: 8px;
padding: $sm-padding;
margin: $sm-padding 0px;
background-color: #eee;
margin: 8px 0px;
border-radius: 8px;
border-radius: $sm-radius;

table {
font-size: 1em;
Expand All @@ -183,12 +252,12 @@ function statusClass(c: CollectorConfig): string {
}

.table-header-padding {
padding: 8px 8px 0px 0px;
padding: $sm-padding $sm-padding 0px $sm-padding;
text-align: left;
}

.table-cell-padding {
padding: 8px 8px 1px 0px;
padding: $sm-padding $sm-padding 1px 0px;
text-align: left;
}
}
Expand All @@ -199,9 +268,9 @@ function statusClass(c: CollectorConfig): string {
align-items: center;
height: 40px;
background-color: #eee;
margin: 8px;
padding: 8px;
border-radius: 8px;
margin: $sm-padding;
padding: $sm-padding;
border-radius: $sm-radius;

h3 {
font-variant: small-caps;
Expand Down
Loading