struct_field_align with shorthand and rest/base #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works with the new target files, but breaks in surprising previously working places. test with cargo +nightly-2025-01-02 test system_tests -- --nocapture
janos-r
force-pushed
the
struct_field_align_with_rest
branch
from
6475e44 to
a371652
Compare
janos-r
force-pushed
the
struct_field_align_with_rest
branch
from
93373ca to
3b86657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I fixed it and I think it works now!
I even found a mistaken issue file where it didn't align even though it should have.
This should be able to close
#3371
#6080
#6096