Skip manifest loading if there are no components/targets to check #4350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While examining the manifest loading issues in #2626, I noticed that for the common case (running just
rustc
), the list of components and targets to check is actually empty. In that case, we parse the manifest for no reason, costing us ~20-30ms on every rustup proxy invocation.This makes the common case of running
rustc
almost as fast as when the toolchain is specified explicitly using e.g.+nightly
, where the components/targets weren't checked before.This does not help the situation where there is a
rust-toolchain.toml
file with custom components and targets, these will be checked as before.Before:
After:
Alternative to #4344.
Related issue: #2626