Skip to content

Conversation

@ChrisDenton
Copy link
Member

This is just a draft I'm posting to gather feedback and maybe discuss implementation details.

The configuration file in this PR tells rustup how to install the needed Visual Studio components. The components are listed per supported host architecture, except that i686 is included with x86_64. The Windows SDK is listed separately because it's independent of architecture and may be skipped if already installed via other means.

I used toml format but this could be json or a simpler key=value format but toml seemed more consistent with other files.

This file will need to be deployed to https://static.rust-lang.org/rustup independently of the rustup release process.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

Nits:

  • Name it vs-components.toml with a hyphen?
  • Maybe Components -> components?
  • How did you come up with the component names? Are there standardized versions of these, either from Rust targets or from the MS ecosystem?

@rami3l
Copy link
Member

rami3l commented Oct 18, 2025

How did you come up with the component names?

@djc The component names come from https://learn.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2022 and cannot be changed.

Not sure if that will change with the VS version, but the current format has the flexibility required to reflect such changes if present.

@ChrisDenton
Copy link
Member Author

I've updated it to address djc's suggestions and added a link to where component names can be found, for future reference.

@rami3l
Copy link
Member

rami3l commented Oct 18, 2025

@ChrisDenton Thanks! Not sure if ?view=vs-2022 is required though. Will that change someday?

@ChrisDenton
Copy link
Member Author

Hm, it isn't strictly necessary. Without it it'll point to the latest stable Visual Studio version which we'd usually want to use. But doing so does require updating the installer url.

@ChrisDenton
Copy link
Member Author

I guess the next step is to wait on the new release process and figure out how publishing this will fit in since it needs to be a separate step (like publishing the website would ideally be),

@rami3l
Copy link
Member

rami3l commented Oct 18, 2025

@ChrisDenton Yes, I do hope that pushing rust-lang/promote-release#84 will eventually give us more freedom on that matter; that said, I have the feeling that I might not know who to contact yet if we want to change the structure of the release repository... Do you have any idea?

cc @Mark-Simulacrum

@ChrisDenton ChrisDenton changed the title Add vscomponents.toml Add vs-components.toml Oct 18, 2025
@ChrisDenton
Copy link
Member Author

We can probably ask on the infra channel on zulip. But it may be worth focusing on getting the main release process done first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants