-
Couldn't load subscription status.
- Fork 984
Add vs-components.toml #4543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add vs-components.toml #4543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me.
Nits:
- Name it
vs-components.tomlwith a hyphen? - Maybe
Components->components? - How did you come up with the component names? Are there standardized versions of these, either from Rust targets or from the MS ecosystem?
@djc The component names come from https://learn.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2022 and cannot be changed. Not sure if that will change with the VS version, but the current format has the flexibility required to reflect such changes if present. |
|
I've updated it to address djc's suggestions and added a link to where component names can be found, for future reference. |
|
@ChrisDenton Thanks! Not sure if |
|
Hm, it isn't strictly necessary. Without it it'll point to the latest stable Visual Studio version which we'd usually want to use. But doing so does require updating the installer url. |
|
I guess the next step is to wait on the new release process and figure out how publishing this will fit in since it needs to be a separate step (like publishing the website would ideally be), |
|
@ChrisDenton Yes, I do hope that pushing rust-lang/promote-release#84 will eventually give us more freedom on that matter; that said, I have the feeling that I might not know who to contact yet if we want to change the structure of the release repository... Do you have any idea? |
|
We can probably ask on the infra channel on zulip. But it may be worth focusing on getting the main release process done first. |
This is just a draft I'm posting to gather feedback and maybe discuss implementation details.
The configuration file in this PR tells rustup how to install the needed Visual Studio components. The components are listed per supported host architecture, except that i686 is included with x86_64. The Windows SDK is listed separately because it's independent of architecture and may be skipped if already installed via other means.
I used toml format but this could be json or a simpler
key=valueformat but toml seemed more consistent with other files.This file will need to be deployed to
https://static.rust-lang.org/rustupindependently of the rustup release process.