Add support for Arm64EC and testing for Arm64 Windows #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
force-pushed
the
arm64ec
branch
5 times, most recently
from
036d9d3 to
ea4df65
Compare
nagisa
reviewed
Oct 2, 2025
| ret | ||
| ENDP | ||
|
|
||
| END |
There was a problem hiding this comment.
What's the difference between this target and the aarch64-*-windows-*? The assembly looks identical and could use aarch64_armasm.asm, no?
There was a problem hiding this comment.
Difference is the name of the functions: Arm64EC requires that functions are prefixed with #
Comment on lines
+28
to
+43
| [target.'cfg(all(windows, not(target_arch = "arm64ec")))'.dependencies.windows-sys] | ||
| version = ">=0.52.0, <0.60.0" | ||
| features = [ | ||
| "Win32_System_Memory", | ||
| "Win32_System_Threading", | ||
| "Win32_Foundation", | ||
| ] | ||
|
|
||
| [target.arm64ec-pc-windows-msvc.dependencies.windows-sys] | ||
| version = ">=0.59.0, <0.60.0" | ||
| features = [ | ||
| "Win32_System_Memory", | ||
| "Win32_System_Threading", | ||
| "Win32_Foundation", | ||
| ] | ||
|
|
There was a problem hiding this comment.
Why not bump windows-sys dep accordingly for all windows targets?
There was a problem hiding this comment.
I'm fine with doing that, although I think that will be a semver breaking change. Let me know if that's what you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm64ec-pc-windows-msvc.aarch64-pc-windows-msvc).i686-pc-windows-msvcon x64 Windows andarm64ec-pc-windows-msvcon Arm64 Windows.