-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organize intrinsic-test
to enable seamless addition of behaviour testing for more architectures
#1758
base: master
Are you sure you want to change the base?
Conversation
9900e81
to
546554d
Compare
The module should be called |
@JamieCunliffe feel free to have a look at this since you are the original author of intrinsic-test. This is part of a GSoC project to extend intrinsic-test to other architectures. |
546554d
to
3ff317f
Compare
Reasoning: 1. Majority of code assumes the usage of `Intrinsic` and related types, which is derived from the JSON structure of the ARM intrinsics JSON source file 2. Further commits will start with extracting common parts of the code (eg: Create C/Rust file, Build C/Rust file, etc)
3ff317f
to
bd0a675
Compare
…ted for different architectures. Next steps: Move the existing ARM-specific implementation into one that fits well with this trait.
5dce230
to
7ff8497
Compare
Are we using the |
a12b4a4
to
ff10311
Compare
|
3068c9d
to
2d1e482
Compare
…le_rust and compare_outputs
e0b0301
to
54a678c
Compare
54a678c
to
2777ceb
Compare
6e8851b
to
a2ce02c
Compare
intrinsic-test
to enable seamless addition of behaviour testing for more architecturesintrinsic-test
to enable seamless addition of behaviour testing for more architectures
intrinsic-test
to enable seamless addition of behaviour testing for more architecturesintrinsic-test
to enable seamless addition of behaviour testing for more architectures
4b8e6cf
to
eb744ee
Compare
753baed
to
7fa9e38
Compare
7fa9e38
to
a6c6e5e
Compare
a6d8dc3
to
66d21bd
Compare
intrinsic-test
to enable seamless addition of behaviour testing for more architecturesintrinsic-test
to enable seamless addition of behaviour testing for more architectures
Updates so far
arm
module, exposing only atest
function atsrc/main.rs
SupportedArchitectureTest
trait that has been implemented forarm
and should be implemented for other architectures too. Allows us to expose functionality like building C/Rust test files and comparing outputs.common
module for reuse by other architectures too.match
block for selection of architectures using thetarget
CLI variable.Reasoning
Intrinsic
type may be specific to architectures, hence the implementation of a trait helps us to abstract the usage of such data types within the architecture-specific module